Re: WIDL: Support remaining basic types

[Alexandre Julliard]

Robert Shearman  writes:
> ChangeLog:
> Eric Kohl 
> WIDL: Support remaining basic types (float, double, small, wchar_t and
> handle_t).

We've been through this before, these patches need to be split, the
gratuitous changes removed, and all the code duplication with the
format codes needs to be avoided. Mike started doing that some time
ago so you probably want to start from his patches.

WIDL: Support remaining basic types

[Robert Shearman]

Alexandre Julliard wrote:
> Robert Shearman  writes:
> > ChangeLog:
> > Eric Kohl 
> > WIDL: Support remaining basic types (float, double, small, wchar_t and
> > handle_t).
>
> We've been through this before, these patches need to be split, the
> gratuitous changes removed, and all the code duplication with the
> format codes needs to be avoided. Mike started doing that some time
> ago so you probably want to start from his patches.

Why weren't his patches applied?

WIDL: Support remaining basic types

[Alexandre Julliard]

Robert Shearman  writes:
> Alexandre Julliard wrote:
> > We've been through this before, these patches need to be split, the
> > gratuitous changes removed, and all the code duplication with the
> > format codes needs to be avoided. Mike started doing that some time
> > ago so you probably want to start from his patches.
>
> Why weren't his patches applied?

There was code in there that looked like copy/paste bugs and that
needed to be retested and confirmed one way or the other.