Re: [PATCH 1/4] mshtml: Get rid of PRBool in nsiface.idl

[Henri Verbeet]

On 15 March 2012 11:54, Jacek Caban  wrote:
> +typedef unsigned char cpp_bool;
> +#define bool cpp_bool
> +cpp_quote("#define PRBool cpp_bool") /* FIXME */

Is there any chance this is going to conflict with bool from
stdbool.h? Technically that's C99, and we don't use C99, but I imagine
it could still be pulled in by some other header.

[PATCH 1/4] mshtml: Get rid of PRBool in nsiface.idl

[Jacek Caban]

On 3/15/12 6:45 PM, Henri Verbeet wrote:
> On 15 March 2012 11:54, Jacek Caban  wrote:
> > +typedef unsigned char cpp_bool;
> > +#define bool cpp_bool
> > +cpp_quote("#define PRBool cpp_bool") /* FIXME */
>
> Is there any chance this is going to conflict with bool from
> stdbool.h? Technically that's C99, and we don't use C99, but I imagine
> it could still be pulled in by some other header.

I would be definitely a bad idea to use bool in C code, but it's not 
what the patch does. Note that this define is in IDL file, so it's used 
only by widl. The actual C type is cpp_bool.

Jacek