Re: Clear an old button text in WM_SETTEXT as Windows does

[Andriy Palamarchuk]

--- Dmitry Timoshkov  wrote:
> Hello.
>
> This is a fix for WineHQ bug #437.
>
> P.S.
> Could somebody with slightly more free time fix
> DrawText(DT_CALCRECT),
> since it returns width much larger than an expected
> value?

Dmitry, I advise you to create a bug for this issue in
Bugzilla with detailed description, so the problem
won't be lost.
If the issue can be fixed by newbie, you can put it in
the list of bug 406, if it is more difficult - to 455.

Andriy

__________________________________________________
Do You Yahoo!?
LAUNCH - Your Yahoo! Music Experience
http://launch.yahoo.com

Clear an old button text in WM_SETTEXT as Windows does

[Dmitry Timoshkov]

"Andriy Palamarchuk"  wrote:
> Dmitry, I advise you to create a bug for this issue in
> Bugzilla with detailed description, so the problem
> won't be lost.
> If the issue can be fixed by newbie, you can put it in
> the list of bug 406, if it is more difficult - to 455.

I won't create a bug without a more close investigation, but I have
no time *at all* now. First of all it should be determined whether
the bug is related to Wine freetype using engine (and whether it's
a freetype or Wine bug) or x11drv font code (once again: whether it's
an x11drv or XFree86 bug).

Clear an old button text in WM_SETTEXT as Windows does

[Tony Lambregts]

Andriy Palamarchuk wrote:
> --- Dmitry Timoshkov  wrote:
> > Hello.
> >
> > This is a fix for WineHQ bug #437.
> >
> > P.S.
> > Could somebody with slightly more free time fix
> > DrawText(DT_CALCRECT),
> > since it returns width much larger than an expected
> > value?
>
> Dmitry, I advise you to create a bug for this issue in
> Bugzilla with detailed description, so the problem
> won't be lost.
> If the issue can be fixed by newbie, you can put it in
> the list of bug 406, if it is more difficult - to 455.

I entered the bug report based on some research and Dmitry's comments. 
 I hope I got it right. Dmitry could you have a look to make sure I 
haven't got it totally screwed up?

http://bugs.winehq.com/show_bug.cgi?id=728

Tony Lambregts

Clear an old button text in WM_SETTEXT as Windows does

[Dmitry Timoshkov]

"Tony Lambregts"  wrote:
> I entered the bug report based on some research and Dmitry's comments.

Tony, many thanks for your efforts. Could you please give more details
regarding your research?
> I hope I got it right. Dmitry could you have a look to make sure I 
> haven't got it totally screwed up?

I'm afraid that the bug is not in the button.c code, but somewhere
in the GDI/x11drv font/text supporting layer.

Clear an old button text in WM_SETTEXT as Windows does

[Tony Lambregts]

Dmitry Timoshkov wrote:
> "Tony Lambregts"  wrote:
> > I entered the bug report based on some research and Dmitry's comments.
>
> Tony, many thanks for your efforts. Could you please give more details
> regarding your research?
> > I hope I got it right. Dmitry could you have a look to make sure I 
> > haven't got it totally screwed up?
>
> I'm afraid that the bug is not in the button.c code, but somewhere
> in the GDI/x11drv font/text supporting layer.

Well you would know better than I would. I was looking at the code from 
the standpoint of where the problem shows up, (where the call is made to 
be more precise). If you think the problem is in the supporting layer 
then I am not about to tell you your wrong.  If you could update the bug 
report with the information you think is relevant (when you have time) I 
would apperciate it.

Tony Lambregts