re: cmd: fixing an issue with extra whitespaces after cd parameter (retry)

[Dan Kegel]

Frédéric Delanoy wote:
> Nowres Rafid wrote:
> > how can I generate the expected file (.exp)?
>
> It already exists in the source tree

I think Nowres meant, how can he update the .exp file
to match the expected output of his new test.

The answer is: run the new test, save its output,
and add it to the .exp file by hand.  It's kind of a pain.

cmd: fixing an issue with extra whitespaces after cd parameter (retry)

[Nowres Rafid]

On 17/08/2011 14:42, Dan Kegel wrote:
> Frédéric Delanoy wote:
> > Nowres Rafid wrote:
> > > how can I generate the expected file (.exp)?
> >
> > It already exists in the source tree
>
> I think Nowres meant, how can he update the .exp file
> to match the expected output of his new test.
>
> The answer is: run the new test, save its output,
> and add it to the .exp file by hand.  It's kind of a pain.

Thank's Dan.

cmd: fixing an issue with extra whitespaces after cd parameter (retry)

[Dan Kegel]

Two more tips:
1) don't send HTML email to wine mailing lists
2) please be sure to run the conformance tests before submitting
patches, and fix any failures

Happily, your patch seems to cause a test to succeed:

...
../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p
cmd.exe_test.exe.so batch.c && touch batch.ok
...
batch.c:241: Test succeeded inside todo block: unexpected char 0x0
position -1 in line 174 (got 'foobar deleted', wanted 'foobar
deleted')
(Log at http://buildbot.kegel.com:8010/builders/runtests/builds/19/steps/shell_3/log...
for a couple days.)

so you'll need to remove the @todo_wine@ from that line of the exp file
to keep the test from complaining that it succeeded when it shouldn't have.

While testing your patch, I found an old bug in cmd that caused
an error message to be output at that point in the test,
and sent http://www.winehq.org/pipermail/wine-patches/2011-August/105433.html
to fix that.