Online at http://kegel.com/wine/valgrind/20071002/ (I now include more info about memory leaks, but I still only report anything if there was an invalid memory reference.)
The following tests were fixed in git yesterday, and no longer have any valgrind warnings: comctl32/rebar comctl32/status crypt32/chain crypt32/crl crypt32/msg cryptnet/cryptnet user32/msg wintrust/softpub
Juan thinks nearly all of the remaining crypt32 errors can be suppressed (some are intentional).
Here are the directories that still have warnings:
advapi32 advpack cabinet comctl32 crypt32 d3d8 d3d9 d3dx8 dplayx dsound gdi32 gdiplus hlink kernel32 mlang msacm32 mscms mshtml msi msvcrt msxml3 netapi32 ntdll ole32 oleaut32 quartz riched20 riched32 rpcrt4 rsaenh setupapi shdocvw shell32 urlmon user32 usp10 wininet winmm wintrust - Dan
On 11/2/07, Dan Kegel dank@kegel.com wrote:
Online at http://kegel.com/wine/valgrind/20071002/
I should mention: I'm not planning fixing any of these myself for now (I'd love to, but I can't afford to type that much). I'm hoping other Wine developers will pitch in to clean the real valgrind errors up & gather suppressions for the false positives. Juan and Lei have already done some cleanup -- thanks, guys! -- but there's a lot more to do.
See http://wiki.winehq.org/Wine_and_Valgrind for more info. - Dan
Am Freitag, 2. November 2007 22:10:28 schrieb Dan Kegel:
On 11/2/07, Dan Kegel dank@kegel.com wrote:
Online at http://kegel.com/wine/valgrind/20071002/
I should mention: I'm not planning fixing any of these myself for now (I'd love to, but I can't afford to type that much). I'm hoping other Wine developers will pitch in to clean the real valgrind errors up & gather suppressions for the false positives. Juan and Lei have already done some cleanup -- thanks, guys! -- but there's a lot more to do.
See http://wiki.winehq.org/Wine_and_Valgrind for more info.
- Dan
With the intel driver warnings filtered out, the d3d results are much easier to real. Looks like we have a bunch of memleaks there. I sent a patch for the CreateVertexDeclaration error already
On Friday 02 November 2007 19:59:10 Dan Kegel wrote:
dplayx
I'm not sure if this is worth the effort right now. It seems to be leaking some memory, but everybody _using_ dplay with wine right now uses native, anyway.
netapi32
That's my fault, working on it.
Cheers, Kai
On Fri, Nov 2, 2007 at 11:59 AM, Dan Kegel dank@kegel.com wrote:
Here are the directories that still have warnings:
advapi32 advpack cabinet comctl32 crypt32 d3d8 d3d9 d3dx8 dplayx dsound gdi32 gdiplus hlink kernel32 mlang msacm32 mscms mshtml msi msvcrt msxml3 netapi32 ntdll ole32 oleaut32 quartz riched20 riched32 rpcrt4 rsaenh setupapi shdocvw shell32 urlmon user32 usp10 wininet winmm wintrust
So, after several months of cleanup, the list of directories with valgrind warnings is down from 40 to 27:
advpack cabinet comctl32 crypt32 d3d8 d3d9 ddraw dsound gdi32 gdiplus kernel32 mlang mshtml msi netapi32 ntdll ole32 qmgr riched20 rpcrt4 shdocvw shell32 urlmon user32 wininet winmm ws2
and the average number of unique warnings per library is down to about 3 1/3.
Changes since Friday morning: - Added five patches by me, one by Chris Smith, one by Alistair - Removed two by me, three by huw, two by jon, and one by Rob that are now in git - added two new suppressions
This gets us down to 90 warnings.
Please join the party! We can use all the help we can get getting rid of these bugs; though many are innocuous to users, a few aren't, and they're all annoying to anyone using valgrind.
Report showing unique nonleak errors: http://kegel.com/wine/valgrind/logs-2008-06-22.counts.txt
Logs: http://kegel.com/wine/valgrind/logs-2008-06-22.log.gz http://kegel.com/wine/valgrind/logs-2008-06-22/
Pending wine patches: http://kegel.com/wine/valgrind/logs-2008-06-22-patches/ http://kegel.com/wine/valgrind/logs-2008-06-22-patches.tgz http://kegel.com/wine/valgrind/logs-2008-06-22-patch.txt
Suppression file: http://kegel.com/wine/valgrind/valgrind-suppressions
-
Dan Kegel -
Kai Blin -
Stefan Dösinger