Re: user/defdlg.c: Just restore focus to current control [Bug:430]

[Richard Cohen]

Vitaliy Margolen wrote:
> Restore focus should not select all text in edit control. Only tabbing into it
> should do that (according to msdn).
>
> Vitaliy Margolen
>
> changelog:
>   user/defdlg.c:
> - Restore focus to the current control without selecting text

As with Vijay's patch, this patch breaks TABbing out of the readonly 
edit field in the testcase to bug 430

Richard.

user/defdlg.c: Just restore focus to current control [Bug:430]

[Vitaliy Margolen]

Friday, October 21, 2005, 5:40:43 AM, Richard Cohen wrote:
> Vitaliy Margolen wrote:
> > Restore focus should not select all text in edit control. Only tabbing into it
> > should do that (according to msdn).
> >
> > Vitaliy Margolen
> >
> > changelog:
> >   user/defdlg.c:
> > - Restore focus to the current control without selecting text
>
> As with Vijay's patch, this patch breaks TABbing out of the readonly 
> edit field in the testcase to bug 430

Hmm, reverting my change didn't fix it. So I would say it was broken before.

Vitaliy

user/defdlg.c: Just restore focus to current control [Bug:430]

[Richard Cohen]

Vitaliy Margolen wrote:
> Hmm, reverting my change didn't fix it. So I would say it was broken before.
>
> Vitaliy

Yes, it seems so