Re: [PATCH] iphlpapi: Ensure GetIpAddrTable returns loopback addresses in the end

[Alexandre Julliard]

Bruno Jesus  writes:
> Manually tested by other people in GNU/Linux and OSX, in every case
> loopback was returned first while in all testbot Windows machines and
> my Windows machines the loopback comes after everything.
>
> Fixes https://bugs.winehq.org/show_bug.cgi?id=40247
> Signed-off-by: Bruno Jesus
>
> dlls/iphlpapi/iphlpapi_main.c  | 27 +++++++++++++++++++++------
>  dlls/iphlpapi/tests/iphlpapi.c |  4 ++++
>  2 files changed, 25 insertions(+), 6 deletions(-)

This breaks the tests here:

../../../tools/runtest -q -P wine -T ../../.. -M ws2_32.dll -p ws2_32_test.exe.so sock && touch sock.ok
sock.c:2489: Tests skipped: SOCK_RAW is not supported
sock.c:6947: Test failed: got 11002 expected WSAHOST_NOT_FOUND
sock.c:6948: Test failed: expected 11001, got 11002
sock.c:7197: Test failed: got 11002 expected WSAHOST_NOT_FOUND
sock.c:7198: Test failed: expected 11001, got 11002
sock.c:8648: Tests skipped: Cannot test SIO_ADDRESS_LIST_CHANGE, interactive tests must be enabled
Makefile:208: recipe for target 'sock.ok' failed
make: *** [sock.ok] Error 4

[PATCH] iphlpapi: Ensure GetIpAddrTable returns loopback addresses in the end

[Bruno Jesus]

On Thu, Dec 1, 2016 at 11:43 AM, Alexandre Julliard  wrote:
> > dlls/iphlpapi/iphlpapi_main.c  | 27 +++++++++++++++++++++------
> >  dlls/iphlpapi/tests/iphlpapi.c |  4 ++++
> >  2 files changed, 25 insertions(+), 6 deletions(-)
>
> This breaks the tests here:
>
> ../../../tools/runtest -q -P wine -T ../../.. -M ws2_32.dll -p ws2_32_test.exe.so sock && touch sock.ok
> sock.c:2489: Tests skipped: SOCK_RAW is not supported
> sock.c:6947: Test failed: got 11002 expected WSAHOST_NOT_FOUND
> sock.c:6948: Test failed: expected 11001, got 11002
> sock.c:7197: Test failed: got 11002 expected WSAHOST_NOT_FOUND
> sock.c:7198: Test failed: expected 11001, got 11002
> sock.c:8648: Tests skipped: Cannot test SIO_ADDRESS_LIST_CHANGE, interactive tests must be enabled
> Makefile:208: recipe for target 'sock.ok' failed
> make: *** [sock.ok] Error 4

Looks like an internet hiccup, do you mind testing again? I usually
test all network related DLL's when changing network code I here I
have no problems. Specially because what you got is TRY_AGAIN error.

[PATCH] iphlpapi: Ensure GetIpAddrTable returns loopback addresses in the end

[Alexandre Julliard]

Bruno Jesus  writes:
> On Thu, Dec 1, 2016 at 11:43 AM, Alexandre Julliard  wrote:
> > > dlls/iphlpapi/iphlpapi_main.c  | 27 +++++++++++++++++++++------
> > >  dlls/iphlpapi/tests/iphlpapi.c |  4 ++++
> > >  2 files changed, 25 insertions(+), 6 deletions(-)
> >
> > This breaks the tests here:
> >
> > ../../../tools/runtest -q -P wine -T ../../.. -M ws2_32.dll -p ws2_32_test.exe.so sock && touch sock.ok
> > sock.c:2489: Tests skipped: SOCK_RAW is not supported
> > sock.c:6947: Test failed: got 11002 expected WSAHOST_NOT_FOUND
> > sock.c:6948: Test failed: expected 11001, got 11002
> > sock.c:7197: Test failed: got 11002 expected WSAHOST_NOT_FOUND
> > sock.c:7198: Test failed: expected 11001, got 11002
> > sock.c:8648: Tests skipped: Cannot test SIO_ADDRESS_LIST_CHANGE, interactive tests must be enabled
> > Makefile:208: recipe for target 'sock.ok' failed
> > make: *** [sock.ok] Error 4
>
> Looks like an internet hiccup, do you mind testing again? I usually
> test all network related DLL's when changing network code I here I
> have no problems. Specially because what you got is TRY_AGAIN error.

It does seem random, yes, sorry about that. I don't remember ever seeing
that error before your change, but maybe that was just luck.