Re: patch for gdi32

[Dan Kegel]

On Wed, Dec 3, 2008 at 1:24 PM, Dan Kegel  wrote:
> Hi Xiangrong,
> you forgot to attach the patch, I think.

Aha.  You attached the wrong format.  We want a plain text file,
i.e. not .odt, but .txt.    The nice description in your .odt/.pdf
belongs in a bug report in http://bugs.winehq.org.
(And, as somebody mentioned, there may be related bugs already,
e.g. http://bugs.winehq.org/show_bug.cgi?id=4065 )

If you don't want to use "git diff" to generate the patch, use 'diff -u'.  See
http://kegel.com/academy/opensource.html#patches

Good luck, and welcome to Wine development!
- Dan

patch for gdi32

[Xiangrong Fang]

Hi Dan,

Thank you for your explanations!

It is indeed bug #4065.  I read the info there, although I don't fully
understand every bit information there, but that is marked as FIXED
and CLOSED?? As far as I know, this is NOT fixed yet, and it affect a
HUGE amount of Chinese applications, those applications are otherwise
perfectly supported by wine.  A very good progress in this area is
that I found Chinese text are more properly auto-wrapped in recent
Wine releases, which is excellent.

About this issue, shall I submit discussion in #4065 or open a new
bug?  (I need to upload some screenshots to illustrate the problem --
this is NOT a missing font problem as discussed).

BTW, for these discussions, shall I use wine-devel or wine-patch?

Please advise.

Thank you!

Sincerely,
Shannon

2008/12/4 Dan Kegel :
> On Wed, Dec 3, 2008 at 1:24 PM, Dan Kegel  wrote:
> > Hi Xiangrong,
> > you forgot to attach the patch, I think.
>
> Aha.  You attached the wrong format.  We want a plain text file,
> i.e. not .odt, but .txt.    The nice description in your .odt/.pdf
> belongs in a bug report in http://bugs.winehq.org.
> (And, as somebody mentioned, there may be related bugs already,
> e.g. http://bugs.winehq.org/show_bug.cgi?id=4065 )
>
> If you don't want to use "git diff" to generate the patch, use 'diff -u'.  See
> http://kegel.com/academy/opensource.html#patches
>
> Good luck, and welcome to Wine development!
> - Dan

patch for gdi32

[Dan Kegel]

On Wed, Dec 3, 2008 at 3:38 PM, Xiangrong Fang  wrote:
> It is indeed bug #4065.  I read the info there, although I don't fully
> understand every bit information there, but that is marked as FIXED
> and CLOSED?? As far as I know, this is NOT fixed yet, and it affect a
> HUGE amount of Chinese applications, those applications are otherwise
> perfectly supported by wine.

I think 4065 was closed because we found what seemed to
be an acceptable way to get that particular app (Picasa) working.
> A very good progress in this area is
> that I found Chinese text are more properly auto-wrapped in recent
> Wine releases, which is excellent.

We are very interested in providing excellent Asian language
support.  We can use all the help we can get, though, as
few Wine developers speak any Asian languages well.
> About this issue, shall I submit discussion in #4065 or open a new
> bug?  (I need to upload some screenshots to illustrate the problem --
> this is NOT a missing font problem as discussed).

Please open a new bug.  If possible, include source code
for a small noninteractive program that demonstrates
the problem.  e.g. a C program that displays a single character
that is wrong in wine but right in windows.
> BTW, for these discussions, shall I use wine-devel or wine-patch?

All discussions go to wine-devel.   When replying to a message
on wine-patches, please change the destination to wine-devel.
- Dan

patch for gdi32

[Markus Hitter]

Am 04.12.2008 um 00:38 schrieb Xiangrong Fang:
> but that is marked as FIXED and CLOSED??

Yes, Wine developers are sometimes pretty quick at closing bugs. The  
sad thing is, you can't comment on closed bugs and have to open a new  
one.
> BTW, for these discussions, shall I use wine-devel or wine-patch?

wine-patches is for patches only, -devel is where discussions should go.

MarKus

- - - - - - - - - - - - - - - - - - -
Dipl. Ing. Markus Hitter
http://www.jump-ing.de/