Re: ntdll / kernel32: #40

[Alexandre Julliard]

Eric Pouech  writes:
> This patch allows to use the UNIX code page inside of ntdll.
> The full change log:
> - moved code page & NLS resources from kernel32 to ntdll
> - moved locale initialisation from kernel32 to ntdll
> - created unix code page handling in ntdll
> - made use of this unix cp for the initial environment creation (in PEB)

I don't think I agree with that. IMO the locale stuff should remain in
kernel32. We can simply set the unix codepage in ntdll the same way we
set the other codepages.

ntdll / kernel32: #40

[Eric Pouech]

> I don't think I agree with that. IMO the locale stuff should remain in
> kernel32. We can simply set the unix codepage in ntdll the same way we
> set the other codepages.

the only issue I have here is that most of the code needed for 
initialisation in has to be called after the unix codepage has been 
guessed, which is only possible after kernel32 has been loaded and its 
wine specific entry point has been called (which means calling back into 
ntdll with wine specific entry points).
So, if I follow you, you would suggest to:
1/ pass the unix codepage (or its table) along the ansi & oem cp
2/ allow, in ntdll.wine_init_codepage, to make further initialization 
(which could depend on the various codepages)

A+

ntdll / kernel32: #40

[Alexandre Julliard]

Eric Pouech  writes:
> So, if I follow you, you would suggest to:
> 1/ pass the unix codepage (or its table) along the ansi & oem cp

Yes.
> 2/ allow, in ntdll.wine_init_codepage, to make further initialization
> (which could depend on the various codepages)

Sure, that's not a problem.