Re: comctl32: Move prototype to header

[Sebastian Lackner]

On 27.01.2017 00:26, André Hentschel wrote:
> Signed-off-by: André Hentschel
>
> dlls/comctl32/comctl32.h | 1 +
>  dlls/comctl32/syslink.c  | 2 --
>  2 files changed, 1 insertion(+), 2 deletions(-)

Any specific reason that you don't use include/shlwapi.h ?

comctl32: Move prototype to header

[Nikolay Sivov]

On 27.01.2017 2:28, Sebastian Lackner wrote:
> On 27.01.2017 00:26, André Hentschel wrote:
> > Signed-off-by: André Hentschel
> >
> > dlls/comctl32/comctl32.h | 1 +
> >  dlls/comctl32/syslink.c  | 2 --
> >  2 files changed, 1 insertion(+), 2 deletions(-)
>
> Any specific reason that you don't use include/shlwapi.h ?

It's internal to comctl32.dll, and is not exported by name. Using
unrelated header would be confusing.

For this specific case it's better to use CompareString directly in
syslink.c and maybe get rid of SYSLINK_StrCmpNIW() of possible.