What's wrong with my patch?

[Jan de Mooij]

Hello.

Subject says it all. I suppose the tests I added may fail on other
locales, but there is no other way to test my patch?
Should i send it without the tests?

Thanks in advance.

Jan

---------- Forwarded message ----------
From: Jan de Mooij 
Date: Mon, Aug 31, 2009 at 2:24 PM
Subject: comctl32/propsheet: update position of hidden buttons too
To: [e-mail]

eMule iterates all buttons to find the left-most button, and then uses
the x and y position for its own buttons.
This currently fails in Wine because we don't update the position of
the hidden buttons.

Tests pass on Vista and Wine (2 failures without this change)

Fixes bug 11345 - http://bugs.winehq.org/show_bug.cgi?id=11345

[Juan Lang]

Hi Jan,
> Subject says it all.

Well, you haven't waited nearly long enough.  Sending it in today and
expecting it to be committed the same day is a bit much.
--Juan

[Jan de Mooij]

On Mon, Aug 31, 2009 at 6:25 PM, Juan Lang wrote:
> Well, you haven't waited nearly long enough.  Sending it in today and
> expecting it to be committed the same day is a bit much.

I saw that AJ committed patches sent before and after my email, so I
assumed he goes through them in order.
Sorry about that.

Thanks,
Jan

[Juan Lang]

> I saw that AJ committed patches sent before and after my email, so I
> assumed he goes through them in order.

It also depends on whether your patch is obviously correct, and your
"Julliard rank."  Since you're new around here, it's likely your patch
will be subject to more scrutiny.  Plus Andrew pointed out that your
email address was invalid in the patch, which means automatic
rejection.

Fix what Andrew says, wait at least a day, and ask for feedback if you
don't get any response after that.

Good luck,
--Juan

[Andrew Eikum]

Jan de Mooij wrote:
> Hello.
>
> Subject says it all. I suppose the tests I added may fail on other
> locales, but there is no other way to test my patch?
> Should i send it without the tests?
>
> Thanks in advance.
>
> Jan

I can't speak much to the patch itself, but the patch file you attached 
has an invalid email address.  You should set user.name and user.email 
in .git/config.  See `man git-config` for more info.

Also, #defining the ID for the apply button without #undefing it seems 
wrong.  I'd use a const INT in the test_buttons method so the scope is 
taken care of automatically.

Andrew