Re: avifil32: Overwrite dwRate in the audiostream with the nBlockAlign from the wave header
On 01/10/2010 03:18 AM, Julius Schwartzenberg wrote:
I was stupid last week and sent patches in a serie that didn't actually depend on each other. I'm resending them properly now. All fixes are actually independent from each other.
I started looking into some problems avifil32 had because Civilization II would crash if it tried to play it's intro movie. I created a small program to print information about the different headers in AVI files and to play back the audio stream. Also with this program, many AVI files failed to play (while they worked on Windows with it). The fixes I introduce also allow my testing program to play back everything correctly.
These patches solve this problem and several other problems.
Hi Julius,
Do any of these patches fix any of the tests? If so you should also change the tests by removing one or more todo_wine()'s.
This could become tricky though if your tests patches are not committed before these ones.
Paul Vriens wrote:
Do any of these patches fix any of the tests? If so you should also change the tests by removing one or more todo_wine()'s.
This could become tricky though if your tests patches are not committed before these ones.
Yes, all the tests work properly with my patches. I had understood that todo_wine should be based on the state of current GIT. But I understand now that normally a fix should remove an existing todo_wine in GIT. Right now I'm indeed not sure how to deal with this since I don't know whether either the tests and/or the fixes will be committed. I kinda hoped Alexandre had some kind of automated way to removed fixed todo_wines...
Indeed stupid I hadn't caught the C++ comment when checking everything. It was even an old leftover, I resent the patch now.
Thanks for the feedback! Julius
Julius Schwartzenberg wrote:
Paul Vriens wrote:
Do any of these patches fix any of the tests? If so you should also change the tests by removing one or more todo_wine()'s.
This could become tricky though if your tests patches are not committed before these ones.
Yes, all the tests work properly with my patches. I had understood that todo_wine should be based on the state of current GIT. But I understand now that normally a fix should remove an existing todo_wine in GIT. Right now I'm indeed not sure how to deal with this since I don't know whether either the tests and/or the fixes will be committed. I kinda hoped Alexandre had some kind of automated way to removed fixed todo_wines...
Nope. AJ does not have an automatic 'todo wine' removal tool. However, you can submit patches as a series, the first patch implements the function, the second removes the todo wine. If the first patch is rejected, then the second one is automatically removed. Again, if the second patch is not changed and you do change the first, you can 'resubmit' the second patch as is with the changed first patch.
James McKenzie
-
James McKenzie -
Julius Schwartzenberg -
Paul Vriens