Re: regedit: stdin is not seekable so do not try to seek the input file if it is not seekable

[Alexandre Julliard]

Aric Stewart  writes:
> programs/regedit/regedit.c |    2 +-
>  programs/regedit/regproc.c |   19 +++++++++++--------
>  programs/regedit/regproc.h |    2 +-
>  3 files changed, 13 insertions(+), 10 deletions(-)

We shouldn't need to seek at all, instead it should be easy to test the
first two bytes of the first line before processing it.

regedit: stdin is not seekable so do not try to seek the input file if it is not seekable

[Aric Stewart]

True, through I did not add the code that was doing the seeking so i 
tried to not be too intrusive.

Should I rework the way we do the line processing to be able to do this 
then?

-aric

Alexandre Julliard wrote:
> Aric Stewart  writes:
> > programs/regedit/regedit.c |    2 +-
> >  programs/regedit/regproc.c |   19 +++++++++++--------
> >  programs/regedit/regproc.h |    2 +-
> >  3 files changed, 13 insertions(+), 10 deletions(-)
>
> We shouldn't need to seek at all, instead it should be easy to test the
> first two bytes of the first line before processing it.

regedit: stdin is not seekable so do not try to seek the input file if it is not seekable

[Alexandre Julliard]

Aric Stewart  writes:
> True, through I did not add the code that was doing the seeking so i
> tried to not be too intrusive.
>
> Should I rework the way we do the line processing to be able to do
> this then?

Yes please.