Re: [PATCH 5/6] dinput: Fix usage of HeapReAlloc.

[Alexandre Julliard]

Vitaliy Margolen  writes:
> -
>    if (!have_joydevs)
> -
>        joydevs = HeapAlloc(GetProcessHeap(), 0, sizeof(struct JoyDev));
> -
>    else
> -
>        joydevs = HeapReAlloc(GetProcessHeap(), 0, joydevs, (1 + have_joydevs) * sizeof(struct JoyDev));
> -
> -
>    if (!joydevs)
> -
>    {
> -
>        close(fd);
> -
>        continue;
> -
>    }

While you are fixing it you should fix it properly by preserving the old
pointer on failure.

[PATCH 5/6] dinput: Fix usage of HeapReAlloc.

[Vitaliy Margolen]

Alexandre Julliard wrote:
> While you are fixing it you should fix it properly by preserving the old
> pointer on failure.

Thanks. Sent fixed patch.

Vitaliy