Hello, please ignore this patch for now.
It seems that systemfontfileenumerator_GetCurrentFontFile uses RegEnumValueW in a way not supported on Windows - with giving NULL parameters for value and/or val_count [1].
When RegEnumValueW is called with proper value parameter the problem with not returning correct count would not happen already.
So, as far as I see, first all uses of RegEnumValue with NULL parameters for value or val_count need a fix.
Kind regards, Bernhard
On 21 Jun 2015, at 20:45, Bernhard Übelacker wrote:
Hello, please ignore this patch for now.
Unfortunately it was committed and is causing test failures (or crashes) on every version of Windows. http://test.winehq.org/data/tests/advapi32:registry.html
Does this need reverting?
Huw.
Am 22.06.2015 um 21:43 schrieb Huw Davies:
On 21 Jun 2015, at 20:45, Bernhard Übelacker wrote:
Hello, please ignore this patch for now.
Unfortunately it was committed and is causing test failures (or crashes) on every version of Windows. http://test.winehq.org/data/tests/advapi32:registry.html
Does this need reverting?
Huw.
Hello Huw, yes please revert.
Right now Wine version of RegEnumValueW supports being called with parameters value and val_count being NULL. (And is used that way at least in systemfontfileenumerator_GetCurrentFontFile.)
The Microsoft implementation unfortunately does this not.
Right now I am trying to find the places in Wine code and try to change them in a Windows compatible way. Later another patch could change RegEnumValueW to check these two parameters.
Should I have sent this ignore request to wine-patches instead/also?
I am very sorry to cause this trouble.
Kind regards, Bernhard
On 22 Jun 2015, at 21:11, Bernhard Übelacker wrote:
Am 22.06.2015 um 21:43 schrieb Huw Davies:
On 21 Jun 2015, at 20:45, Bernhard Übelacker wrote:
Hello, please ignore this patch for now.
Unfortunately it was committed and is causing test failures (or crashes) on every version of Windows. http://test.winehq.org/data/tests/advapi32:registry.html
Does this need reverting?
Hello Huw, yes please revert.
Ok, I've sent a patch to revert.
Should I have sent this ignore request to wine-patches instead/also?
No, you did the right thing. AJ must have missed it.
Huw.
Am 22.06.2015 um 22:32 schrieb Huw Davies:
On 22 Jun 2015, at 21:11, Bernhard Übelacker wrote:
Should I have sent this ignore request to wine-patches instead/also?
No, you did the right thing. AJ must have missed it.
This was probably also my fault. Because as I saw that the tests were getting faults on testbot I hit the "cancel" button.
That way the failing result was not transferred from testbot back to patchwatcher.
Kind regards, Bernhard
Bernhard Übelacker bernhardu@vr-web.de writes:
Am 22.06.2015 um 22:32 schrieb Huw Davies:
On 22 Jun 2015, at 21:11, Bernhard Übelacker wrote:
Should I have sent this ignore request to wine-patches instead/also?
No, you did the right thing. AJ must have missed it.
This was probably also my fault. Because as I saw that the tests were getting faults on testbot I hit the "cancel" button.
That way the failing result was not transferred from testbot back to patchwatcher.
Yes, if you do that, I don't get the failure notice in my patch list, so please avoid it. Sorry for missing your message to wine-devel.
-
Alexandre Julliard -
Bernhard Übelacker -
Huw Davies -
Huw Davies