On Sun, Dec 2, 2018 at 5:40 PM Alistair Leslie-Hughes leslie_alistair@hotmail.com wrote:
Hi Alex,
How about stealing the ones from staging, they have been improved more than the ones you sent in. https://github.com/wine-staging/wine-staging/tree/master/patches/ntdll-RtlAd...
The main difference in the staging patches is that they add the functions to winnt.h too. Since Alexandre doesn't like adding functions to the header files before they have a proper implementation, I think the patches that I sent today are more likely to be accepted. My new patches also have the advantage of making RtlAddGrowableFunctionTable on x64 call RtlAddFunctionTable (which has an x64 implementation already) instead of just doing nothing.
-Alex
Hi Alex
On 3/12/18 3:16 pm, Alex Henrie wrote:
The main difference in the staging patches is that they add the functions to winnt.h too. Since Alexandre doesn't like adding functions to the header files before they have a proper implementation, I think the patches that I sent today are more likely to be accepted. My new patches also have the advantage of making RtlAddGrowableFunctionTable on x64 call RtlAddFunctionTable (which has an x64 implementation already) instead of just doing nothing.
no problems.
arm64 also needs these functions.
Alistair.
On Mon, Dec 3, 2018 at 12:18 AM Alistair Leslie-Hughes leslie_alistair@hotmail.com wrote:
Hi Alex
On 3/12/18 3:16 pm, Alex Henrie wrote:
The main difference in the staging patches is that they add the functions to winnt.h too. Since Alexandre doesn't like adding functions to the header files before they have a proper implementation, I think the patches that I sent today are more likely to be accepted. My new patches also have the advantage of making RtlAddGrowableFunctionTable on x64 call RtlAddFunctionTable (which has an x64 implementation already) instead of just doing nothing.
no problems.
arm64 also needs these functions.
Good catch! I'll send a new version.
-Alex
-
Alex Henrie -
Alistair Leslie-Hughes