Re: CodeWeaver's patches

[Gerard Patel]

At 01:57 AM 1/28/02 -0500, you wrote:
> I have finished doing that with one exception: the ListView. This one will
> require a lot more work due to the fact that it was extensively modified.
> I will work on the listview.c file this week, as I have some of my own
> changes that I need to cleanup and submit, as well as CW's changes.

Speaking of listview, I have issues with your last changes :
notification is broken. I can see it with Eudora 4, but I have a test
app in Python that I can send you if you want.

I attach the changes I did to get Eudora working again

Note that the change in notify() is unrelated, I just noticed the
problem when searching the notification problem.

Also the following change

-    if (*ppszText == NULL)
-       *lpLVItem->pszText = '\0';

is not related to your changes, this was broken a very long time
ago. It's just that it makes listview work again for columns > 0.

If you think to send your changes soon, maybe you could
use my changes or implement them to your liking. Else I can
send them myself (if you don't object to my changes), as
you prefer.

Gerard

CodeWeaver's patches

[Dimitrie O. Paun]

On Mon, 28 Jan 2002, Gerard Patel wrote:
> Speaking of listview, I have issues with your last changes :
> notification is broken. I can see it with Eudora 4, but I have a test
> app in Python that I can send you if you want.

Of course I'd like that, if it's not too much to ask.
> If you think to send your changes soon, maybe you could
> use my changes or implement them to your liking. Else I can
> send them myself (if you don't object to my changes), as
> you prefer.

It's OK, just go ahead and submit them, I'll work from them as soon as
Alexandre starts commiting stuff.

Thanks for finding and fixing the bugs.

--
Dimi.

P.S. Looking at CW's patch, I realized that I forgot to do the conversion
on the way back in the LVN_GETDISPINFO notification...