Re: wine.inf: update registry key

[Dmitry Timoshkov]

"Louis. Lenders"  wrote:
> Hi, this fixes bug #7953 -> http://bugs.winehq.org/show_bug.cgi?id=7953
> Vitaly said this one won't go as it might break another app, but i don't
> get that , as the key in windows looks quite the same,

No it doesn't in the default Windows setup, and the key was changed for a reason
to make Picasa work some time ago:

http://source.winehq.org/git/wine.git/?a=commitdiff;h=f03c86a27387cd1dc27c37...

wine.inf: update registry key

[Louis. Lenders]

Dmitry Timoshkov  wrote: "Louis. Lenders"  wrote:
> Hi, this fixes bug #7953 -> http://bugs.winehq.org/show_bug.cgi?id=7953
> Vitaly said this one won't go as it might break another app, but i don't
> get that , as the key in windows looks quite the same,

No it doesn't in the default Windows setup, and the key was changed for a reason
to make Picasa work some time ago:

http://source.winehq.org/git/wine.git/?a=commitdiff;h=f03c86a27387cd1dc27c37...

wine.inf: update registry key

[Dmitry Timoshkov]

"Louis. Lenders"  wrote:
> I cannot check how it looks in a default Windows setup anymore, as i
> installed another browser (mozilla) on my windowsXP installation. However,
> there's one thing I don't get: the key on my WinXp installation does have
> that extra "%1" now, so would that mean that picasa would crash on my
> windowsXp installation after i installed, or do things work differently
> there?

Picasa doesn't crash on any setup (and the problem is not a crash but not
working help items), and as far as I know help in Picasa works with Mozilla
installed in XP. But that means that if you want to introduce not standard
registry setup you need to make sure that applications still work, i.e.
ShellExecute behaves properly in both cases. Right now adding %1 breaks
ShellExecute in Wine.