Re: Józef Kucia : wined3d: Implement indirect draws.

[Ken Thomases]

Hi Józef,

On Nov 2, 2017, at 5:28 PM, Alexandre Julliard  wrote:
> Module: wine
> Branch: master
> Commit: f4aa2911a689f95783fe2061a516440dc3d3f39e
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f4aa2911a689f95783fe2061a5...
>
> Author: Józef Kucia 
> Date:   Wed Nov  1 22:08:42 2017 +0100
>
> wined3d: Implement indirect draws.

If I'm reading this commit correctly, the new indexed indirect draw code does not make use of state->index_offset (via idx_data, for example).  Is that how it should be?  Or should DrawIndexedInstancedIndirect() respect the index buffer offset?

Thanks,
Ken

Józef Kucia : wined3d: Implement indirect draws.

[Józef Kucia]

On Fri, Nov 3, 2017 at 9:54 AM, Ken Thomases  wrote:
> Hi Józef,
>
> On Nov 2, 2017, at 5:28 PM, Alexandre Julliard  wrote:
> > Module: wine
> > Branch: master
> > Commit: f4aa2911a689f95783fe2061a516440dc3d3f39e
> > URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f4aa2911a689f95783fe2061a5...
> >
> > Author: Józef Kucia 
> > Date:   Wed Nov  1 22:08:42 2017 +0100
> >
> > wined3d: Implement indirect draws.
>
> If I'm reading this commit correctly, the new indexed indirect draw code does not make use of state->index_offset (via idx_data, for example).  Is that how it should be?  Or should DrawIndexedInstancedIndirect() respect the index buffer offset?

Thanks for asking. I've submitted a simple test and a patch adding
FIXME() message.