Wine: Possible typo in dll/msxml3/tests/domdoc.c

[Michael Karcher]

Hello Huw Davies,

it looks like test_removeChild (introduced by you in commit 187ab1c0)
contains a typo. The test passes both ways, but from the code flow I
suspect that node_list2 was obtained for a reason, namely using it.

Regards,
  Michael Karcher

This patch fixes the type, if it turn out to really be a typo.

diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 29bebb9..0494e9f 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -1785,7 +1785,7 @@ static void test_removeChild(void)
     r = IXMLDOMNode_get_childNodes( node, &node_list2 );
     ok( r == S_OK, "ret %08x\n", r);

-    r = IXMLDOMNodeList_get_item( node_list, 0, &node4 );
+    r = IXMLDOMNodeList_get_item( node_list2, 0, &node4 );
     ok( r == S_OK, "ret %08x\n", r);

r = IXMLDOMElement_removeChild( element, NULL, &node2 );

[Michael Karcher]

Am Samstag, den 04.10.2008, 20:44 +0200 schrieb Michael Karcher:
> Hello Huw Davies,
>
> it looks like test_removeChild (introduced by you in commit 187ab1c0)
> contains a typo.

Ugh. Please disregard the previous mail. The test after "fixing" the
typo does *not* succeed in WinXP, only in wine.

Regards,
  Michael Karcher

[Michael Karcher]

[resend, as I used a non-subscribed From: in the first try]

Am Samstag, den 04.10.2008, 20:44 +0200 schrieb Michael Karcher:
> Hello Huw Davies,
>
> it looks like test_removeChild (introduced by you in commit 187ab1c0)
> contains a typo.

Ugh. Please disregard the previous mail. The test after "fixing" the
typo does *not* succeed in WinXP, only in wine.

Regards,
  Michael Karcher

[Michael Karcher]

Am Samstag, den 04.10.2008, 21:00 +0200 schrieb Michael Karcher:
> > it looks like test_removeChild (introduced by you in commit 187ab1c0)
> > contains a typo.
>
> Ugh. Please disregard the previous mail. The test after "fixing" the
> typo does *not* succeed in WinXP, only in wine.

Last followup on this thread, hopefully.

It looks like it indeed was a typo, and from that typo wrong conclusions
about the behavior of native were made. I have a modified testcase and a
patch for wine to better match native behavior ready (A series of three
patches up to now). As I am going to continue working on msxml3 now, I
will submit the whole stuff in a couple of hours as one series.

Regards,
  Michael Karcher