[PATCH] comctl32: Fix rounding in premultiplied alpha conversion for static control bitmap image.
Signed-off-by: Jinoh Kang jinoh.kang.kr@gmail.com --- dlls/comctl32/static.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/dlls/comctl32/static.c b/dlls/comctl32/static.c index 7a3ac958111..9b20e6a8b66 100644 --- a/dlls/comctl32/static.c +++ b/dlls/comctl32/static.c @@ -203,6 +203,17 @@ static HBITMAP create_alpha_bitmap( HBITMAP hbitmap ) DeleteObject( alpha ); alpha = 0; } + else + { + /* pre-multiply by alpha */ + for (i = 0, ptr = bits; i < bm.bmWidth * bm.bmHeight; i++, ptr += 4) + { + unsigned int alpha = ptr[3]; + ptr[0] = (ptr[0] * alpha + 127) / 255; + ptr[1] = (ptr[1] * alpha + 127) / 255; + ptr[2] = (ptr[2] * alpha + 127) / 255; + } + } }
DeleteDC( hdc );
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=110478
Your paranoid android.
=== debian11 (32 bit report) ===
comctl32: static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44
=== debian11 (32 bit Chinese:China report) ===
comctl32: static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44
=== debian11 (32 bit WoW report) ===
comctl32: static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44
=== debian11 (64 bit WoW report) ===
comctl32: static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:169: Test succeeded inside todo block: bits: 05 09 0e 44 static.c:199: Test succeeded inside todo block: bits: 05 09 0e 44
-
Jinoh Kang -
Marvin