We only need this debug channel when we're later using it - and all uses in this file are guarded by #ifdef HAVE_LDAP, so use the same guard here as well.
Thanks to Nikolay for this hint based on an earlier patch.
Signed-off-by: Gerald Pfeifer gerald@pfeifer.com --- dlls/wldap32/add.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dlls/wldap32/add.c b/dlls/wldap32/add.c index 0a24d95f32..f5796a6fd7 100644 --- a/dlls/wldap32/add.c +++ b/dlls/wldap32/add.c @@ -34,7 +34,9 @@ #include "wldap32.h" #include "wine/debug.h"
+#ifdef HAVE_LDAP WINE_DEFAULT_DEBUG_CHANNEL(wldap32); +#endif
#ifdef HAVE_LDAP static LDAPMod *nullattrs[] = { NULL };
Gerald Pfeifer gerald@pfeifer.com writes:
We only need this debug channel when we're later using it - and all uses in this file are guarded by #ifdef HAVE_LDAP, so use the same guard here as well.
All the other files in wldap32 have the same issue.
On Mon, 3 Feb 2020, Alexandre Julliard wrote:
We only need this debug channel when we're later using it - and all uses in this file are guarded by #ifdef HAVE_LDAP, so use the same guard here as well.
All the other files in wldap32 have the same issue.
I noticed and if that patch is fine will follow-up with all the others (prepared between this submission and your mail) in one piece. Okay for you?
Gerald
Gerald Pfeifer gerald@pfeifer.com writes:
On Mon, 3 Feb 2020, Alexandre Julliard wrote:
We only need this debug channel when we're later using it - and all uses in this file are guarded by #ifdef HAVE_LDAP, so use the same guard here as well.
All the other files in wldap32 have the same issue.
I noticed and if that patch is fine will follow-up with all the others (prepared between this submission and your mail) in one piece. Okay for you?
Yes, please send all the changes (including the first one) in a single patch.
-
Alexandre Julliard -
Gerald Pfeifer