re: Vehicle for minor bugs?

[Dan Kegel]

Andrew Talbot wrote:
> Frequently, I am finding minor bugs that I probably cannot fix myself, that
> are probably not suitable for a Bugzilla bug report and that are likely to
> be ignored if posted to wine-devel (witness my current postings: "XBOOL,
> XBYTE, XINT8, etc." and "Five functions that cannot handle a NULL
> parameter",

I haven't seen those posts, where are they?

I'd say a conformance test would be the right vehicle.

Vehicle for minor bugs?

[Andrew Talbot]

Dan Kegel wrote:
> Andrew Talbot wrote:
> > witness my current
> > postings: "XBOOL, XBYTE, XINT8, etc." and "Five functions that cannot
> > handle a NULL parameter",
>
> I haven't seen those posts, where are they?

Hi Dan,

I posted them to wine-devel on Saturday.
> I'd say a conformance test would be the right vehicle.

Often this is so. But some bugs may not be revealed by such a test. Also,
sometimes it would be useful to ask an expert what was intended by a bit of
code. For example, consider the following code (from
mshtml/mshtmloption.c), to pick something at random:

static HRESULT WINAPI HTMLOptionElementFactory_create(...)
{
    ...
    HRESULT hres;

...

hres = IHTMLDOMNode_QueryInterface(...);

'''

return S_OK;
}

In this function, either "hres" is an unused variable, or the function
should really return "hres" at the end. I have no way of knowing, but I
would like to be able to bring this to the attention of the mshtml guys so
they can make a judgment from their knowledge of what this function is
about.

Thanks,

Vehicle for minor bugs?

[Jacek Caban]

Hi Andrew,

Andrew Talbot wrote:
> Often this is so. But some bugs may not be revealed by such a test. Also,
> sometimes it would be useful to ask an expert what was intended by a bit of
> code. For example, consider the following code (from
> mshtml/mshtmloption.c), to pick something at random:
>
> static HRESULT WINAPI HTMLOptionElementFactory_create(...)
> {
>     ...
>     HRESULT hres;
> ...
>
> hres = IHTMLDOMNode_QueryInterface(...);
>
> '''
>
> return S_OK;
>
> }
>
> In this function, either "hres" is an unused variable, or the function
> should really return "hres" at the end. I have no way of knowing, but I
> would like to be able to bring this to the attention of the mshtml guys so
> they can make a judgment from their knowledge of what this function is
> about.

IHTMLDOMNode_QueryInterface should never fail here. If it fails, there is something seriously wrong going on. But, anyway, to handle the failure correctly, we could add check hres after releasing nselem like:

if(FAILED(hres))
    return hres;

Jacek