Re: Janitorial : Use Compiler Warnings ( -Wmissing-declarations ) ( #1, take 2 )

[Alexandre Julliard]

Rémi Assailly  writes:
> diff -u libs/wine/debug.c libs/wine/debug.c
> --- libs/wine/debug.c	2005-01-10 20:12:34.748897920 +0100
> +++ libs/wine/debug.c	2005-01-10 19:18:26.000000000 +0100
> @@ -61,6 +61,9 @@
>      return strcmp( name, *chan + 1 );
>  }
>
> +void *__wine_dbg_register( char * const *channels, int nb );
> +void __wine_dbg_unregister( void *channel );

This is useless, please don't add such code only to quiet optional
warnings.
> diff -u include/wine/unicode.h include/wine/unicode.h
> --- include/wine/unicode.h	2005-01-09 12:09:03.000000000 +0100
> +++ include/wine/unicode.h	2005-01-10 19:23:51.000000000 +0100
> @@ -95,6 +95,8 @@
>  extern int vsprintfW( WCHAR *str, const WCHAR *format, va_list valist );
>  extern int vsnprintfW( WCHAR *str, size_t len, const WCHAR *format, va_list valist );
>
> +extern int get_decomposition(WCHAR src, WCHAR *dst, unsigned int dstlen);
> -

get_decomposition is an internal function, it shouldn't be exported in
the public header.