Hey,
Wouldn't it be nice to have a description of every screen at the screenshot page of winehq.com? To know what you see, I don't know half the programs I see on those screens.
I have made a patch for the site file. The patch needs a a description.txt file inside /images/shots/ in this form: [screen# out of the filename]|[screen dexcription] Example: "1|Wine doing default Windows programs"
Next descriptions on a new line.
I've not edited the template but the patch adds a $des_[#] to the available vars.
This is my first attemp to do something for winehq. So, are you interested in descriptions for screenshots?
Regards,
Paul van Schayck
On Wed, 25 Feb 2004, Paul van Schayck wrote:
This is my first attemp to do something for winehq. So, are you interested in descriptions for screenshots?
Paul,
Thank you for your contribution. I think having a description for each image is a really good idea. However, I don't think I like having all descriptions lumped together in one file. What about this: for a image named wine_xx.png, we can create a file called wine_xx.txt in say images/shots/ (or in images/shots/description/). Jer?
BTW: I don't much care for the current scheme of having the images split in different directories. All related files should sit together. Maybe we should have things named: wine_xx-thumb.png, wine_xx-full.png, wine_xx-desc.txt. Anyway, this is not important now, but I thought I'd mention it. This way related files will list together when you do a 'ls', it's more intuitive, and you don't have to read the README to figure things out (ant by the way, I found out about the full/ dir by mistake, when I looked in the README just for kicks :)).
On Wed, 2004-02-25 at 10:46, Dimitrie O. Paun wrote:
On Wed, 25 Feb 2004, Paul van Schayck wrote:
This is my first attemp to do something for winehq. So, are you interested in descriptions for screenshots?
Thank you for your contribution. I think having a description for each image is a really good idea. However, I don't think I like having all descriptions lumped together in one file. What about this: for a image named wine_xx.png, we can create a file called wine_xx.txt in say images/shots/ (or in images/shots/description/). Jer?
I also think the idea of having screenshot descriptions is a good idea. I also agree with Dimi here (say it's not so!), having a simple text file for each shot. I would use my simple xml parser thing to do it (since it already exists). You create a file for each shot, 'wine_xx.xml', then get the description with the get_xml_tags() func.
The xml file would look like this:
<screenshot> <description> hey, you can write stuff here.. </description> </screenshot>
then in the code, called like this:
list($description) = get_xml_tags($file_root.'/images/shots/wine_'.$c.'.xml',array('description'));
Ha!, it seems like I just wrote it all now. I'll add the code, you can create the XML description files if you desire.
Jeremy,
On Wed, 25 Feb 2004 11:13:28 -0600, Jeremy Newman wrote:
I also think the idea of having screenshot descriptions is a good idea. I also agree with Dimi here (say it's not so!), having a simple text file for each shot. I would use my simple xml parser thing to do it (since it already exists). You create a file for each shot, 'wine_xx.xml', then get the description with the get_xml_tags() func.
Ha!, it seems like I just wrote it all now. I'll add the code, you can create the XML description files if you desire.
Everything except the template. But yeah, using an already existing function is better. Anyway, here is my version. With .desc files. Just to test sending patches inline without ruining the patch. Not tested, only checked on syntax.
Regards,
Paul
=================================================================== RCS file: /home/wine/lostwages/site,v retrieving revision 1.3 diff -u -r1.3 site --- site 16 Dec 2003 17:09:26 -0000 1.3 +++ site 25 Feb 2004 17:38:00 -0000 @@ -211,6 +211,21 @@
// Grab list of images from screenshot dir $shots = get_files($file_root."/images/shots","png"); + + // Get description files (*.desc) + $descrip_files = array(); + $descrip_files = get_files($file_root."/images/shots","desc"); + + // Get an array of description in this form: + // $descriptions[file name] = description + foreach($descrip_files as $value) + { + @$descrip_file = file("/images/shots/$value"); + + $description = implode('',$descrip_file); + + $descriptions[$value] = $value[1]; + }
// setup vars $total = count($shots) + 1; @@ -229,6 +244,9 @@
// display image $vars['im_'.$num] = $html->ahref($html->img($file_root.'/images/shots/wine_'.$c.'.png'), $file_root.'/images/shots/full/wine_'.$c.'.png'); + + // Description (if available) + $vars['des_' . $num] = $descriptions["wine_$c.desc"];
// end at 9 if ($num == 9 or $num == $total)
On Wed, 25 Feb 2004, Jeremy Newman wrote:
The xml file would look like this:
<screenshot> <description> hey, you can write stuff here.. </description> </screenshot>
Well, having this XML only for description is a bit useless, isn't it? But if you like it so much, why not use the XML features, and give up on the restrictive naming:
<screenshot> <thumb>wine_someimage.png</thumb> <large>full/wine_someimage.png</thumb> <description> hey, you can write stuff here.. </description> </screenshot>
or we can do (if you want to keep the fixed locations):
<screenshot> <name>wine_someimage.png</name> <description> hey, you can write stuff here.. </description> </screenshot>
or maybe:
<screenshot name="wine_someimage.png"> <description> hey, you can write stuff here.. </description> </screenshot>
And if so, why stick them into shots/desc? Put them into shots/ directly, they drive the entire thing. And we should move the thumbnails into a thumb/ dir for consistency...
On Wednesday 25 February 2004 18:57, Dimitrie O. Paun wrote:
Well, having this XML only for description is a bit useless, isn't it? But if you like it so much, why not use the XML features, and give up on the restrictive naming:
Yeah I agree.
<screenshot> <thumb>wine_someimage.png</thumb> <large>full/wine_someimage.png</large> <description> hey, you can write stuff here.. </description> </screenshot>
And if so, why stick them into shots/desc? Put them into shots/ directly, they drive the entire thing. And we should move the thumbnails into a thumb/ dir for consistency...
No I think we should just make it possible to put them everywhere. This here above looks nice. So make a file screenshots.xml in the top directory with all paths and descriptions of all screens. And we can decide later where to put them.
Regards,
Paul
Jeremy,
On Wednesday 25 February 2004 18:57, Dimitrie O. Paun wrote:
<screenshot> <thumb>wine_someimage.png</thumb> <large>full/wine_someimage.png</large> <description>hey, you can write stuff here..</description> </screenshot>
I have totally rewritten the view_screenshot() function. It now parses the screenshots.xml file with the layout like above. All paths are relative to the /images/shots directory. Output in $vars is the same.
I've also made the /images/shots/screenshots.xml file with all current screens. Added some new descriptions.
Patches submitted to wine-patches. Tell me what you think.
Regards,
Paul van Schayck
-
Dimitrie O. Paun -
Jeremy Newman -
Paul van Schayck