game patches

[Serge Ryabchun]

comments in spec

[Lionel Ulmer]

I think these are WineX patches.. So you should clean the parts that are NOT
WineX specific and resubmit them only here.. Moreover, it is often preferred
(even recommanded) to NOT send a huge patch with a bunch of unrelated diffs
in it but atomic changes.

For example, why mix D3D changes, OpenGL changes and DGA2 changes
considering that they all are related to different games / applications ?

As for the pure WineX changes, I do not know where to submit :-)

For some changes, see my comments embedded..

Lionel
> --- wine-cvs/graphics/x11drv/opengl.c	Wed Aug 29 22:37:08 2001
> +++ wine/graphics/x11drv/opengl.c	Sat Jul 20 10:07:05 2002
> @@ -200,7 +200,7 @@
>    ppfd->nVersion = 1;
>
> /* These flags are always the same... */
> - ppfd->dwFlags = PFD_DRAW_TO_WINDOW | PFD_SUPPORT_OPENGL | PFD_GENERIC_ACCELERATED;
> - ppfd->dwFlags = PFD_DRAW_TO_WINDOW | PFD_SUPPORT_OPENGL | PFD_SWAP_COPY;
> /* Now the flags extraced from the Visual */
> ENTER_GL();
> glXGetConfig(gdi_display, vis, GLX_DOUBLEBUFFER, &value); if (value) ppfd->dwFlags |= PFD_DOUBLEBUFFER;

Which application needs to have the 'PFD_SWAP_COPY' flag set ?
> --- wine-cvs/include/wingdi.h	Mon Apr 22 10:01:17 2002
> +++ wine/include/wingdi.h	Sat Jul 20 13:22:05 2002
> @@ -3345,6 +3345,39 @@
>  BOOL      WINAPI PolyTextOutW(HDC,PPOLYTEXTW,INT);
>  #define   PolyTextOut WINELIB_NAME_AW(PolyTextOut)
>
> +/* These defines are used by wglSwapLayerBuffers */
> +#define WGL_SWAP_MAIN_PLANE (1 <<  0)

(snip)
> - WARN("Following layers unhandled : %08x\n", fuPlanes);
> - }
> -
> - return TRUE;
>
> }
>
> /***********************************************************************

Well, this part is actually one of my patches submitted to WineHQ some time
ago :-)
> # Prefix used for the local variables
> -$ext_prefix = "func_";
> +$ext_prefix = "";
>  # If set to 1, generate TRACEs for each OpenGL function
> -$gen_traces = 1;
> +$gen_traces = 0;

Why change the 'ext_prefix' ? I could understand that you want more speed
and remove the (mostly useless now) ENTER/LEAVE calls and the TRACES, but
that one I do not understand :-)

(big snip removed)

[Serge Ryabchun]

On Mon, 29 Jul 2002, Lionel Ulmer wrote:
> I think these are WineX patches..

yes, sorry, but these patches and spec for them who want to play games
for example SeriousSam, HL or WarCraftIII with more speed and who
used winex ;-)

just rpm -bs; rpm -rebuild --target i686; rpm -i; enjoy ;-)
> Which application needs to have the 'PFD_SWAP_COPY' flag set ?

SeriousSam & SeriousSam-SE, comments for this was in .spec.
> Well, this part is actually one of my patches submitted to WineHQ some time
> ago :-)

sure, comments for this was in .spec too
> > -$ext_prefix = "func_";
> > +$ext_prefix = "";
>
> Why change the 'ext_prefix' ?

oops ;-) but and for this was comments in .spec ;-)

[Jesse Allen]

> On Mon, 29 Jul 2002, Lionel Ulmer wrote:
>
> yes, sorry, but these patches and spec for them who want to play games
> for example SeriousSam, HL or WarCraftIII with more speed and who
> used winex ;-)

I would imagine that you would want these for that very reason =)  That's
why I use wine though, now.

And the part about War3,  well that's paid off hugely for me, because I
set about in the beta improving framerate.  Well I got opengl working and
built a linux from scratch (optimized for my processor) during a period of
three months.  I get _higher_ framerates in War3 under linux than I do in
windows now.

Jesse

[Lionel Ulmer]

> yes, sorry, but these patches and spec for them who want to play games
> for example SeriousSam, HL or WarCraftIII with more speed and who
> used winex ;-)

Yeah, I must have misunderstood your mail then. I thought that you wanted to
submit this patch for inclusion in WineHQ.

And well, I was reading the mail over a slow link (the packets did at last
two Atlantic crossings :-) ), I did not read the complete .spec file.

Lionel

[Ove Kaaven]

On Mon, 29 Jul 2002, Lionel Ulmer wrote:
> I think these are WineX patches..

Well, I don't know what they're based on, but none of these patches are
actually in WineX... I assume that the system shock patch won't help on
wine since ddraw textures aren't much use without D3D, but I guess some
might apply to wine too...
> As for the pure WineX changes, I do not know where to submit :-)

Maybe something like [e-mail] ?