We'll want to perform this move of error_page() and the renaming of calls to it in a single patch.
Chris
On Wednesday 28 June 2006 1:21 pm, Jonathan Ernst wrote:
Changelog:
- new util_show_error_page that will replace errorpage
Chris Morgan wrote:
We'll want to perform this move of error_page() and the renaming of calls to it in a single patch.
Chris
Gah! you have not been listening. You know by now that I think that is a bad idea. I'm preaty sure Jonathan would not be advers to sending a series of patches (1 or x..) for this.
Chris Please do not continue to ignore me. You obviously have a lot more free time on your hands than I do at the moment. But that does not mean I am not involved here. You cannot treat the AppDB like you own little sandbox.
On Wednesday 28 June 2006 1:21 pm, Jonathan Ernst wrote:
Changelog:
- new util_show_error_page that will replace errorpage
This is a rename of one function to another, and a move from one file to another.
Lets not make this into a project when it can be performed by a simple search and replace and verified with a grep of the source code after the change.
I'm not trying to ignore you here btw. Give me a hand with our unit testing so we can turn hours of manual testing into seconds of automated testing. This ultimately is the only way we can really be sure any given patch doesn't break things.
Chris
On Wednesday 28 June 2006 3:01 pm, Tony Lambregts wrote:
Chris Morgan wrote:
We'll want to perform this move of error_page() and the renaming of calls to it in a single patch.
Chris
Gah! you have not been listening. You know by now that I think that is a bad idea. I'm preaty sure Jonathan would not be advers to sending a series of patches (1 or x..) for this.
Chris Please do not continue to ignore me. You obviously have a lot more free time on your hands than I do at the moment. But that does not mean I am not involved here. You cannot treat the AppDB like you own little sandbox.
On Wednesday 28 June 2006 1:21 pm, Jonathan Ernst wrote:
Changelog:
- new util_show_error_page that will replace errorpage
Chris Morgan wrote:
This is a rename of one function to another, and a move from one file to another.
Lets not make this into a project when it can be performed by a simple search and replace and verified with a grep of the source code after the change.
Too often I've seen these things combine changes, The "while I am at it" patch. I see that Jonathan did break this up the proper way.
[AppDb] [try2] util_show_error_page [AppDb] factor exit calls after util_show_error_page
On an different note. None of Jonathan's patches show up in the archive. It only shows his PGP signature.
http://www.winehq.org/pipermail/wine-patches/2006-June/028079.html
--
Tony Lambregts.
-
Chris Morgan -
Tony Lambregts