Re: Alexandre Julliard : server: Class and global atoms should not be local to a window station.

[Alasdair Sinclair]

Hi

This patch breaks firefox-1.5 on fedora core 4 (x86-64).

err:ole:CoGetClassObject class {4955dd33-b159-11d0-8fcf-00aa006bcc59}
not registered
err:ole:CoGetClassObject no class object
{4955dd33-b159-11d0-8fcf-00aa006bcc59} could be created for for context 0x1
fixme:ole:CoCreateInstance no classfactory created for CLSID
{4955dd33-b159-11d0-8fcf-00aa006bcc59}, hres is 0x80040154
wine: Unhandled page fault on write access to 0x0000001a at address
0x6033e436 (thread 0009), starting debugger...
WineDbg starting on pid 0x8
Unhandled exception: page fault on write access to 0x0000001a in 32-bit
code (0x6033e436).
fixme:dbghelp:sffip_cb NIY on
'c:\builds\tinderbox\Fx-Mozilla1.8\WINNT_5.2_Depend\mozilla\xpcom\build\xpcom_core.pdb'
Register dump:
  CS:0023 SS:002b DS:002b ES:002b FS:1007 GS:0063
  EIP:6033e436 ESP:7fa0f790 EBP:7fa0f7c0 EFLAGS:00010246(   - 00
-RIZP1)
  EAX:00000001 EBX:7f5e866c ECX:00000000 EDX:7fa0f704
  ESI:00000000 EDI:7fa0fd18
Stack dump:
0x7fa0f790:  0001002a 7f5c580a 0001002a 00000113
0x7fa0f7a0:  00000000 0000139c 7fca1cf9 7f5e866c
0x7fa0f7b0:  7fa0f7c0 7f5e866c 0001002a 7fa0fd18
0x7fa0f7c0:  7fa0f800 7f5c6490 6033e417 0001002a
0x7fa0f7d0:  00000113 00000000 0000139c 7e270598
0x7fa0f7e0:  7fa0f9ac 7fa0f824 7f595f80 00000113
0200: sel=1007 base=7fe6a000 limit=00001fff 32-bit rw-
Backtrace:
=>1 0x6033e436 in xpcom_core (+0x2e436) (0x6033e436)
   2 0x7f5c6490 WINPROC_CallWndProc+0x70(hwnd=<register not in topmost
frame>, wParam=0x0, lParam=0x139c) [/ppp/wine/wine-git/dlls
/user/winproc.c:418] in user32 (0x7f5c6490)
   3 0x7f5cd2de CallWindowProcW+0x12e(func=0x7f624c34, hwnd=0x1002a,
msg=0x113, wParam=0x0, lParam=0x139c) [/ppp/wine/wine-git/dll
s/user/winproc.c:3095] in user32 (0x7f5cd2de)
   4 0x7f5926ff DispatchMessageW+0xaf(msg=0x7fa0fd18)
[/ppp/wine/wine-git/dlls/user/message.c:3001] in user32 (0x7f5926ff)
fixme:dbghelp:sffip_cb NIY on
'c:\builds\tinderbox\Fx-Mozilla1.8\WINNT_5.2_Depend\mozilla\browser\app\firefox.pdb'
   5 0x0051866b in firefox (+0x11866b) (0x0051866b)
   6 0x007fd417 in firefox (+0x3fd417) (0x007fd417)
   7 0x00401012 in firefox (+0x1012) (0x00401012)
   8 0x7fc8a00c start_process+0xec(arg=0x0)
[/ppp/wine/wine-git/dlls/kernel/process.c:845] in kernel32 (0x7fc8a00c)
   9 0xf7fcc4f7 wine_switch_to_stack+0x17 in libwine.so.1 (0xf7fcc4f7)

Alexandre Julliard wrote:
> Module: wine
> Branch: refs/heads/master
> Commit: 9873494ced8405113381266b4d99c2a9f3002cb1
> URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=9873494ced8405113381266b...
>
> Author: Alexandre Julliard 
> Date:   Wed Mar 22 22:13:40 2006 +0100
>
> server: Class and global atoms should not be local to a window station.
>
> dlls/user/tests/winstation.c |   43 +++++++++++++++++++++++++++++++++++++++++-
>  server/atom.c                |   27 ++++++++++++++++----------
>  server/class.c               |   24 ++++-------------------
>  3 files changed, 62 insertions(+), 32 deletions(-)
>
> diff --git a/dlls/user/tests/winstation.c b/dlls/user/tests/winstation.c
> index 4bc1941..a595718 100644
> --- a/dlls/user/tests/winstation.c
> +++ b/dlls/user/tests/winstation.c