[PATCH] user32/tests: Fix test that has been successful.

[Zhiyi Zhang]

On 7/2/20 10:15 AM, Jiajin Cui wrote:
> 0001-user32-tests-Fix-test-that-has-been-successful.patch
>
> From 5c3930407ac0e313121d56f760e4ad998f233e65 Mon Sep 17 00:00:00 2001
> From: Jiajin Cui 
> Date: Thu, 2 Jul 2020 09:59:46 +0800
> Subject: [PATCH] user32/tests: Fix test that has been successful.
>
> Someone has fixed the issue of the ShowWindow parameter as SW_MINIMIZE, but no fix to the test code.
> Signed-off-by: Jiajin Cui
>
> dlls/user32/tests/msg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
> index f84525a0bf..51091e3408 100644
> --- a/dlls/user32/tests/msg.c
> +++ b/dlls/user32/tests/msg.c
> @@ -5186,7 +5186,7 @@ static void test_messages(void)
>  ShowWindow(hwnd, SW_MINIMIZE);
>  flush_events();
> - ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
> -
>
> ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);
> flush_sequence();
>
> if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE)

See https://www.winehq.org/pipermail/wine-devel/2019-May/146430.html
It is not fixed on FVWM, which is the window manager that TestBots use.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=74620

Your paranoid android.

=== build (build log) ===

error: patch failed: dlls/user32/tests/msg.c:5186
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/user32/tests/msg.c:5186
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/user32/tests/msg.c:5186
Task: Patch failed to apply

[Jiajin Cui]

Hi Zhiyi，
    Thank you for your reply, I was revising other issues that were found in the testbot verification, which seemed to be only good at the time.
> On 7/2/20 10:15 AM, Jiajin Cui wrote:
> > 0001-user32-tests-Fix-test-that-has-been-successful.patch
> >
> > From 5c3930407ac0e313121d56f760e4ad998f233e65 Mon Sep 17 00:00:00 2001
> > From: Jiajin Cui 
> > Date: Thu, 2 Jul 2020 09:59:46 +0800
> > Subject: [PATCH] user32/tests: Fix test that has been successful.
> >
> > Someone has fixed the issue of the ShowWindow parameter as SW_MINIMIZE, but no fix to the test code.
> > Signed-off-by: Jiajin Cui
> >
> > dlls/user32/tests/msg.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
> > index f84525a0bf..51091e3408 100644
> > --- a/dlls/user32/tests/msg.c
> > +++ b/dlls/user32/tests/msg.c
> > @@ -5186,7 +5186,7 @@ static void test_messages(void)
> >  
> >       ShowWindow(hwnd, SW_MINIMIZE);
> >       flush_events();
> > -    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
> > +    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);
> >       flush_sequence();
> >  
> >       if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE)
>
> See https://www.winehq.org/pipermail/wine-devel/2019-May/146430.html
> It is not fixed on FVWM, which is the window manager that TestBots use.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=74619

Your paranoid android.

=== w1064v1809_ja (32 bit report) ===

user32:
msg: Timeout

=== debiant (64 bit WoW report) ===

user32:
msg.c:5219: Test failed: SetWindowPos:Resize: 6: in msg 0x0047 expecting wParam 0x1012 got 0x1812
msg.c:5236: Test failed: SetWindowPos:ResizePopup: 6: in msg 0x0047 expecting wParam 0x1012 got 0x1812