Re: shdocvw: implement IWebBrowser2::get_LocationName

[Jacek Caban]

Hi Andrey,

On 5/9/10 9:30 PM, Andrey Turkin wrote:
> dlls/shdocvw/tests/webbrowser.c |   27 ++++++++++++++++++++++++---
>  dlls/shdocvw/webbrowser.c       |   24 ++++++++++++++++++++++--
>  2 files changed, 46 insertions(+), 5 deletions(-)

+    if (This->doc_host.document&&  SUCCEEDED(IUnknown_QueryInterface(
+            This->doc_host.document,&IID_IHTMLDocument2, (void**)&doc))) {
+        hres = IHTMLDocument2_get_title(doc, LocationName);
+        IHTMLDocument2_Release(doc);

There is no reason to make this MSHTML-specific by using IHTMLDocument2 
here.

Jacek

shdocvw: implement IWebBrowser2::get_LocationName

[Andrey Turkin]

10.05.2010 15:02, Jacek Caban wrote:
> Hi Andrey,
>
> On 5/9/10 9:30 PM, Andrey Turkin wrote:
> > dlls/shdocvw/tests/webbrowser.c |   27 ++++++++++++++++++++++++---
> >  dlls/shdocvw/webbrowser.c       |   24 ++++++++++++++++++++++--
> >  2 files changed, 46 insertions(+), 5 deletions(-)
> - if (This->doc_host.document&&  SUCCEEDED(IUnknown_QueryInterface(
> -
>        This->doc_host.document,&IID_IHTMLDocument2, 
>
> (void**)&doc))) {
> -
>    hres = IHTMLDocument2_get_title(doc, LocationName);
> -
>    IHTMLDocument2_Release(doc);
>
>
> There is no reason to make this MSHTML-specific by using 
> IHTMLDocument2 here.
>
> Jacek

If there is more generic way to get HTML title for the document then it 
certainly can be used instead; I just don't know any - hints/suggestions 
would be welcome.