Re: [PATCH 2/3] wininet/tests: Added more tests for urlcache, including a new flag in CacheEntryType.
Hi,
On 04/05/12 08:50, Morten Rønne wrote: diff --git a/include/wininet.h b/include/wininet.h #define URLHISTORY_CACHE_ENTRY 0x00200000 +#define DELETED_CACHE_ENTRY 0x00400000 #define TRACK_OFFLINE_CACHE_ENTRY 0x00000010
DELETED_CACHE_ENTRY is not defined in native wininet.h header that I have. Did you find a header with it? If not, it should not be defined there.
Cheers, Piotr
Dear Piotr
I have found the flag by testing urlcache functions and look into the cache. After that I added it together with the other definitions of that flag field. As this is sort of internal to urlcache, I wouldn't be surprised if this is not defined in any official header.
How should I go about moving it? Should the patch (as it has been commited) be removed from wine or should I send a new one, based on the current state?
Best Regards Morten Rønne
Den 06-04-2012 13:27, Piotr Caban skrev:
Hi,
On 04/05/12 08:50, Morten Rønne wrote: diff --git a/include/wininet.h b/include/wininet.h #define URLHISTORY_CACHE_ENTRY 0x00200000 +#define DELETED_CACHE_ENTRY 0x00400000 #define TRACK_OFFLINE_CACHE_ENTRY 0x00000010
DELETED_CACHE_ENTRY is not defined in native wininet.h header that I have. Did you find a header with it? If not, it should not be defined there.
Cheers, Piotr
On 4/7/12 12:48 PM, Morten Rønne wrote:
How should I go about moving it? Should the patch (as it has been commited) be removed from wine or should I send a new one, based on the current state?
Send a new patch based on current state. You can also change it a little later, e.g. while improving DeleteUrlCacheEntry implementation.
-
Morten Rønne -
Piotr Caban