Re: secur32: return success on graceful close of SSL connection

[Ken Thomases]

On Feb 20, 2014, at 3:41 PM, Aric Stewart wrote:
> dlls/secur32/schannel_macosx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/dlls/secur32/schannel_macosx.c b/dlls/secur32/schannel_macosx.c
> index 5d88223..1d1df26 100644
> --- a/dlls/secur32/schannel_macosx.c
> +++ b/dlls/secur32/schannel_macosx.c
> @@ -989,6 +989,8 @@ SECURITY_STATUS schan_imp_recv(schan_imp_session session, void *buffer,
>          else
>              TRACE("Read %lu bytes before would block\n", *length);
>      }
> - else if (status == errSSLClosedGraceful)
> -
>    return SEC_E_OK;
> else
>    {
>        WARN("SSLRead failed: %ld\n", (long)status);

Every other path has a log line.  You could add one to this case, but it's probably just sufficient to put an "or" clause in the noErr condition:

if (status == noErr || status == errSSLClosedGraceful)
        TRACE("Read %lu bytes\n", *length);

-Ken