"Mike McCormack" mike@codeweavers.com wrote:
On Slackware 8.1, this caused a screenful of warnings for *every* file compiled, which makes it difficult to see important warnings.
Same on RH 6.2. But it's actually bug(s) in string.h and a better way IMHO is just fix it, instead of silencing warnings if a user is *really* annoyed by that avalanche of warnings.
Dmitry Timoshkov wrote:
Same on RH 6.2. But it's actually bug(s) in string.h and a better way IMHO is just fix it, instead of silencing warnings if a user is *really* annoyed by that avalanche of warnings.
I agree that it is a bug in string.h, and that it would be better if it were fixed, but I think most people will not go to the hastle of modifying their string.h or upgrading their headers... IMO it is cleaner to not make the warnings. People who have good headers will have wine compiled with -Wpointer-arith, and can fix and warnings that they see.
Personally I'd rather not mess with the default header files on my system, as I'd problem screw them up, and thus screw up every program I built ;)
Mike
"Mike McCormack" mike@codeweavers.com wrote:
I agree that it is a bug in string.h, and that it would be better if it were fixed, but I think most people will not go to the hastle of modifying their string.h or upgrading their headers... IMO it is cleaner to not make the warnings. People who have good headers will have wine compiled with -Wpointer-arith, and can fix and warnings that they see.
I.e. are you proposing to build a potentially broken Wine binaries instead of fixing a probable source of bug? Is there a point in turning warnings on if nobody pays attention to them or even tries to get rid of them if they annoy enough?
Personally I'd rather not mess with the default header files on my system, as I'd problem screw them up, and thus screw up every program I built ;)
Complain to your distribution owner then and make them fix the bug for you.
Wine works around other problems on the build platform (eg. strength-reduce bug, detected a few lines after my patch in configure.ac). I don't see how broken headers are any different from a broken compiler or broken libraries, which we already detect and deal with in the configure script.
Mike
Dmitry Timoshkov wrote:
I.e. are you proposing to build a potentially broken Wine binaries instead of fixing a probable source of bug? Is there a point in turning warnings on if nobody pays attention to them or even tries to get rid of them if they annoy enough?
"Mike McCormack" mike@codeweavers.com wrote:
Wine works around other problems on the build platform (eg. strength-reduce bug, detected a few lines after my patch in configure.ac). I don't see how broken headers are any different from a broken compiler or broken libraries, which we already detect and deal with in the configure script.
Compiler optimization bugs and bugs in the system headers are two very different things. The former can be easily and without any harm disabled, while the latter is completely unavoidable at all without a replacement.
-
Dmitry Timoshkov -
Mike McCormack