Charles Davis wrote:
I added this to clang yesterday. Now clang will warn every time it encounters the force_align_arg_pointer attribute applied to a function pointer. This isn't a problem on Linux, but on Mac OS X those warnings are going to clutter the output, since we use it so liberally.
All right, since you're not convinced this is a good idea, let me, well, convince you.
The conversation I had on the cfe-commits mailing list: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027361.h... (my original commit) http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027392.h... (someone suggesting the warning) http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027395.h... (someone else seconding it) http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027396.h... (me saying no) http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027397.h... (a third person suggesting the switch) http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027420.h... (me caving)
An incomplete list of projects that use force_align_arg_pointer: - liboil - ffmpeg - x264 - Gallium3D - KDE
Just do a Google search for 'force_align_arg_pointer' and you'll see a whole bunch of pages about this!
Now are you convinced this is a good idea?
Chip
Charles Davis cdavis@mymail.mines.edu writes:
An incomplete list of projects that use force_align_arg_pointer:
- liboil
- ffmpeg
- x264
- Gallium3D
- KDE
Just do a Google search for 'force_align_arg_pointer' and you'll see a whole bunch of pages about this!
Now are you convinced this is a good idea?
No, I still don't see the point of warning about a completely harmless usage. It's clearly convenient to be able to define __stdcall the way we do in Wine, and I expect other projects may want to it that way too. OTOH the likelihood that someone would deliberately use it on a function pointer expecting something to happen seems very low to me, and not worth a warning, much less a command-line option.
Alexandre Julliard wrote:
Charles Davis cdavis@mymail.mines.edu writes:
An incomplete list of projects that use force_align_arg_pointer:
- liboil
- ffmpeg
- x264
- Gallium3D
- KDE
Just do a Google search for 'force_align_arg_pointer' and you'll see a whole bunch of pages about this!
Now are you convinced this is a good idea?
No, I still don't see the point of warning about a completely harmless usage. It's clearly convenient to be able to define __stdcall the way we do in Wine, and I expect other projects may want to it that way too. OTOH the likelihood that someone would deliberately use it on a function pointer expecting something to happen seems very low to me, and not worth a warning, much less a command-line option.
You win.
I reverted the change that led to the warning. You can safely discard my patch now.
Chip
-
Alexandre Julliard -
Charles Davis