Re: TestBot job 86609 results: [PATCH 3/4] include: Add DIPROPPOINTER definition.

[Arkadiusz Hiler]

On Mon, Mar 08, 2021 at 07:07:01AM -0600, Marvin wrote:
> VM                   Status   Failures Command
> debiant2             failed   10       
> debiant2             failed   10
>
> You can also see the results at:
> https://testbot.winehq.org/JobDetails.pl?Key=86609
>
> === debiant2 (32 bit report) ===
>
> dinput:
> mouse.c:152: Test failed: Failed: 00000001
> mouse.c:158: Test failed: Failed: 80070005
> mouse.c:161: Test failed: Failed: 00000001
> mouse.c:164: Test failed: Failed: 80070005
> mouse.c:178: Test failed: GetDeviceData() failed: 00000000 cnt:0
>
> === debiant2 (32 bit Chinese:China report) ===
>
> dinput:
> mouse.c:152: Test failed: Failed: 00000001
> mouse.c:158: Test failed: Failed: 80070005
> mouse.c:161: Test failed: Failed: 00000001
> mouse.c:164: Test failed: Failed: 80070005
> mouse.c:178: Test failed: GetDeviceData() failed: 00000000 cnt:0
>
> === debiant2 (32 bit WoW report) ===
>
> dinput:
> mouse.c:152: Test failed: Failed: 00000001
> mouse.c:158: Test failed: Failed: 80070005
> mouse.c:161: Test failed: Failed: 00000001
> mouse.c:164: Test failed: Failed: 80070005
> mouse.c:178: Test failed: GetDeviceData() failed: 00000000 cnt:0
>
> === debiant2 (64 bit WoW report) ===
>
> dinput:
> mouse.c:152: Test failed: Failed: 00000001
> mouse.c:158: Test failed: Failed: 80070005
> mouse.c:161: Test failed: Failed: 00000001
> mouse.c:164: Test failed: Failed: 80070005
> mouse.c:178: Test failed: GetDeviceData() failed: 00000000 cnt:0

Those tests got run by the bot because of dinput.h change, but there no
difference in behaviour vs the current upstream.

Clean run: https://testbot.winehq.org/JobDetails.pl?Key=86616#k301

TestBot job 86609 results: [PATCH 3/4] include: Add DIPROPPOINTER definition.

[Francois Gouget]

On Mon, 8 Mar 2021, Arkadiusz Hiler wrote:
> On Mon, Mar 08, 2021 at 07:07:01AM -0600, Marvin wrote:
> > VM                   Status   Failures Command
> > debiant2             failed   10       
> > debiant2             failed   10
> >
> > You can also see the results at:
> > https://testbot.winehq.org/JobDetails.pl?Key=86609

[...]
> Those tests got run by the bot because of dinput.h change, but there no
> difference in behaviour vs the current upstream.
>
> Clean run: https://testbot.winehq.org/JobDetails.pl?Key=86616#k301

Actually job 86609 is the clean run and 86616 is the dirty one.

* In job 86609 each Wine run got 5 _preexisting_ failures but no new 
  ones so this qualifies as a clean run.

* Job 86616 got the same 5 preexisting failures but had one extra new 
  failure. So it's not a clean run.

Note that the 'TestBot job results' emails are sent to the developer 
regardless of whether there are new errors or not.

Maybe this email should be reworked to be clearer and specifically 
indicate whether there are new failures (and appeal to the developer to 
try and fix preexisting ones). It's also somewhat redundant with the 
mailing list email which is only sent in case of new failures.