Re: wine/dlls/setupapi parser.c

[Robert Shearman]

Alexandre Julliard wrote:
> Index: wine/dlls/setupapi/parser.c
> diff -u -p wine/dlls/setupapi/parser.c:1.15 wine/dlls/setupapi/parser.c:1.16
> --- wine/dlls/setupapi/parser.c:1.15	Tue May 31 17:10:06 2005
> +++ wine/dlls/setupapi/parser.c	Tue May 31 17:10:06 2005
> @@ -852,7 +852,9 @@ static DWORD parse_buffer( struct inf_fi
>     struct parser parser;
>     const WCHAR *pos = buffer;
> - parser.start       = buffer;
> - if (*pos == 0xfeff) pos++;  /* skip Unicode BOM signature */
> -
> - parser.start       = pos;
> parser.end         = end;
> parser.file        = file;
> parser.line        = NULL;

This shouldn't be necessary. The Unicode BOM (or Zero Width Non-Breaking 
Space) has CT_CTYPE1 of C1_SPACE | C1_BLANK so it should be skipped just 
like any other whitespace character.

wine/dlls/setupapi parser.c

[Alexandre Julliard]

Robert Shearman  writes:
> Alexandre Julliard wrote:
> > Index: wine/dlls/setupapi/parser.c
> > diff -u -p wine/dlls/setupapi/parser.c:1.15 wine/dlls/setupapi/parser.c:1.16
> > --- wine/dlls/setupapi/parser.c:1.15	Tue May 31 17:10:06 2005
> > +++ wine/dlls/setupapi/parser.c	Tue May 31 17:10:06 2005
> > @@ -852,7 +852,9 @@ static DWORD parse_buffer( struct inf_fi
> >     struct parser parser;
> >     const WCHAR *pos = buffer;
> > - parser.start       = buffer;
> > - if (*pos == 0xfeff) pos++;  /* skip Unicode BOM signature */
> > -
> > - parser.start       = pos;
> > parser.end         = end;
> > parser.file        = file;
> > parser.line        = NULL;
>
> This shouldn't be necessary. The Unicode BOM (or Zero Width
> Non-Breaking Space) has CT_CTYPE1 of C1_SPACE | C1_BLANK so it should
> be skipped just like any other whitespace character.

Hmmm I guess you are right. It seemed to help at the time but that may
have been because of the various problems with RtlIsTextUnicode.