Re: msvcirt/tests: Add initial tests for streambuf

[Piotr Caban]

On 06/02/15 12:47, Iván Matellanes wrote:
> +todo_wine{
> - /* constructors */
> - call_func1(p_streambuf_ctor, &sb);

You'll need to add streambuf_ctor stub in wine before you can test it. 
Currently the tests will fail with exception. Please also set &sb memory 
to something so you can detect uninitialized values.

Please also call streambuf_dtor.

Cheers,
Piotr

msvcirt/tests: Add initial tests for streambuf

[Iván Matellanes]

I have already implemented those methods. Is it OK if I skip the stubs and send the implementation directly?

Thanks,
Iván

El 02/06/15 a las 13:12, Piotr Caban escribió:
> On 06/02/15 12:47, Iván Matellanes wrote:
> > +todo_wine{
> > - /* constructors */
> > - call_func1(p_streambuf_ctor, &sb);
>
> You'll need to add streambuf_ctor stub in wine before you can test it. Currently the tests will fail with exception. Please also set &sb memory to something so you can detect uninitialized values.
>
> Please also call streambuf_dtor.
>
> Cheers,
> Piotr

msvcirt/tests: Add initial tests for streambuf

[Piotr Caban]

On 06/02/15 13:25, Iván Matellanes wrote:
> I have already implemented those methods. Is it OK if I skip the stubs and send the implementation directly?

Probably it's OK, if the patches are to hard to review you'll be asked 
to split them. The idea is to keep patches small so it's easier to 
review them.