Fixing the kernel32:actctx tests on Vista+

[Paul Vriens]

Hi Jacek,

You are the original author of these tests. Is there any reason the 
"test3.manifest" name is reused?

The tests currently crash (intermittently on some) on Vista+ and with 
the attached patch things seem to get better. I'm just renaming one of 
the manifest files so there are no duplicates in these tests.

[Jacek Caban]

Hi Paul,

Paul Vriens wrote:
> Hi Jacek,
>
> You are the original author of these tests. Is there any reason the 
> "test3.manifest" name is reused?
>
> The tests currently crash (intermittently on some) on Vista+ and with 
> the attached patch things seem to get better. I'm just renaming one of 
> the manifest files so there are no duplicates in these tests.

I don't remember much about these tests, but looking at the code I don't 
see any reason to reuse the name, so your patch looks good for me.

Thanks,
    Jacek

[Paul Vriens]

On 11/25/2009 05:39 PM, Jacek Caban wrote:
> Hi Paul,
>
> Paul Vriens wrote:
> > Hi Jacek,
> >
> > You are the original author of these tests. Is there any reason the
> > "test3.manifest" name is reused?
> >
> > The tests currently crash (intermittently on some) on Vista+ and with
> > the attached patch things seem to get better. I'm just renaming one of
> > the manifest files so there are no duplicates in these tests.
>
> I don't remember much about these tests, but looking at the code I don't
> see any reason to reuse the name, so your patch looks good for me.

Well, it was 2007 ;)

Btw. another patch (see attached patch2) works as well and is basically 
the same thing that Ge did back in September to these same tests.

So both work fine. Any favors for one over the other?

[Jacek Caban]

Paul Vriens wrote:
> On 11/25/2009 05:39 PM, Jacek Caban wrote:
> > Hi Paul,
> >
> > Paul Vriens wrote:
> > > Hi Jacek,
> > >
> > > You are the original author of these tests. Is there any reason the
> > > "test3.manifest" name is reused?
> > >
> > > The tests currently crash (intermittently on some) on Vista+ and with
> > > the attached patch things seem to get better. I'm just renaming one of
> > > the manifest files so there are no duplicates in these tests.
> >
> > I don't remember much about these tests, but looking at the code I don't
> > see any reason to reuse the name, so your patch looks good for me.
>
> Well, it was 2007 ;)
>
> Btw. another patch (see attached patch2) works as well and is 
> basically the same thing that Ge did back in September to these same 
> tests.
>
> So both work fine. Any favors for one over the other?

Both seem good for me. I think that a new file name is slightly better, 
because it feels safer than cheating cache mechanisms.

Jacek

[improve pctools]

I hope this article will help you fix the 
http://www.improve-pc-tools.com/index.php/how-to-fix-kernel32dll-errors/
kernel32 error  on vista.

Jacek Caban-2 wrote:
> Paul Vriens wrote:
> > On 11/25/2009 05:39 PM, Jacek Caban wrote:
> > > Hi Paul,
> > >
> > > Paul Vriens wrote:
> > > > Hi Jacek,
> > > >
> > > > You are the original author of these tests. Is there any reason the
> > > > "test3.manifest" name is reused?
> > > >
> > > > The tests currently crash (intermittently on some) on Vista+ and with
> > > > the attached patch things seem to get better. I'm just renaming one of
> > > > the manifest files so there are no duplicates in these tests.
> > >
> > > I don't remember much about these tests, but looking at the code I don't
> > > see any reason to reuse the name, so your patch looks good for me.
> >
> > Well, it was 2007 ;)
> >
> > Btw. another patch (see attached patch2) works as well and is 
> > basically the same thing that Ge did back in September to these same 
> > tests.
> >
> > So both work fine. Any favors for one over the other?
>
> Both seem good for me. I think that a new file name is slightly better, 
> because it feels safer than cheating cache mechanisms.
>
> Jacek

[Tom Wickline]

The below lin is a 404,  the correct link is :

http://www.improve-pc-tools.com/index.php/how-to-fix-kernel32dll-errors/

Tom

On Thu, Dec 3, 2009 at 5:00 PM, improve pctools wrote:
> I hope this article will help you fix the
> http://www.improve-pc-tools.com/index.php/how-to-fix-kernel32dll-errors/
> kernel32http://www.improve-pc-tools.com/index.php/how-to-fix-kernel32dll-errors/%0Akernel32error  on vista.
>
> Jacek Caban-2 wrote:
> > Paul Vriens wrote:
> > > On 11/25/2009 05:39 PM, Jacek Caban wrote:
> > > > Hi Paul,
> > > >
> > > > Paul Vriens wrote:
> > > > > Hi Jacek,
> > > > >
> > > > > You are the original author of these tests. Is there any reason the
> > > > > "test3.manifest" name is reused?
> > > > >
> > > > > The tests currently crash (intermittently on some) on Vista+ and with
> > > > > the attached patch things seem to get better. I'm just renaming one of
> > > > > the manifest files so there are no duplicates in these tests.
> > > >
> > > > I don't remember much about these tests, but looking at the code I
>
> don't
> > > > see any reason to reuse the name, so your patch looks good for me.
> > >
> > > Well, it was 2007 ;)
> > >
> > > Btw. another patch (see attached patch2) works as well and is
> > > basically the same thing that Ge did back in September to these same
> > > tests.
> > >
> > > So both work fine. Any favors for one over the other?
> >
> > Both seem good for me. I think that a new file name is slightly better,
> > because it feels safer than cheating cache mechanisms.
> >
> > Jacek
>
> --
> View this message in context:
> http://old.nabble.com/Fixing-the-kernel32%3Aactctx-tests-on-Vista%2B-tp26515...
> Sent from the Wine - Devel mailing list archive at Nabble.com.

[Tom Wickline]

Hmm.. the article looks like SPAM,  well at least it has a correct link
now.. :)

On Fri, Dec 4, 2009 at 1:02 AM, Tom Wickline  wrote:
> The below lin is a 404,  the correct link is :
>
> http://www.improve-pc-tools.com/index.php/how-to-fix-kernel32dll-errors/
>
> Tom

[Tom Wickline]

Looks like SPAM, oh well at least it has a fixed link now.

Geez,

Tom

On Fri, Dec 4, 2009 at 1:02 AM, Tom Wickline  wrote:
> The below lin is a 404,  the correct link is :
>
> http://www.improve-pc-tools.com/index.php/how-to-fix-kernel32dll-errors/
>
> Tom