Wine cabinet.dll FDI Conformace Test Patch

[Rizwan Kassim]

Folks,

Aleksandr Liber and I have put together a set of tests for
 cabinet.dll. Before we submit them to wine-patches, can anyone offer
 any critiques/input? We plan to submit in a day or two.

We're 4th+ year undergraduate students at the UCLA Computer Science
 program. We're among a group of students doing conformance tests as
 part of a software engineering course - more info can be found at
 http://www.geekymedia.com/wine

Any advice you can offer will be greatly appreciated!

--
 Thank you,
 Rizwan Kassim

***** Patch message follows *****

Wine cabinet.dll FDI Conformace Test Patch (gzipped)

Raw files available at :
 http://www.geekymedia.com/viewcvs/cgi/viewcvs.cgi/group3/wine/

This patch adds tests for the cabinet dll, specifically testing the
 functions FDICreate, FDIDestroy, FDICopy and FDIIsCabinet. As the
 FCI functions are still marked TODO in wine, they haven't been tested.

The package is self containing, allowing additional cabinet
 features to be tested by preparing other cabinets in the same manner
 that ours were.  A patch of -p1 will be needed.

Changelog:'
  * configure.ac
    added dlls/cabinet/tests/Makefile to be generated
  * dlls/cabinet/Makefile.in
    added subdirectory reference
  * dlls/cabinet/tests/Makefile.in
    standard Makefile.in for tests
  * dlls/cabinet/tests/cabinet_fdi.c
    actual test code for FDICreate, FDIDestroy, FDIIsCabinet, FDICopy
  * dlls/cabinet/tests/data.h
    contains hex representations of the two test cabinets
  * dlls/cabinet/tests/tvfs.h
  * dlls/cabinet/tests/tvfs.c
    Trivial Virtual File System emulating _read, _write, _open, _lseek
and _close
  * dlls/cabinet/tests/genfiles.sh
    Cabinet/data.h creation script used for simple.cab and
complex.cab- current tests
  * tools/chexify.pl
    converts input files to C style arrays

Signed-off-by: Rizwan Kassim 
 Signed-off-by: Dan Kegel 
 Signed-off-by: Aleksandr Liber

[Andreas Mohr]

Hi,

On Sun, Feb 27, 2005 at 10:21:15PM -0800, Rizwan Kassim wrote:
> Folks,
>
> Aleksandr Liber and I have put together a set of tests for
>  cabinet.dll. Before we submit them to wine-patches, can anyone offer
>  any critiques/input? We plan to submit in a day or two.

Cool stuff!

It's wonderful to have people work on OSS projects such as Wine
during study tasks.
(your project has been announced before, but I'm commenting on this now only)
> Any advice you can offer will be greatly appreciated!

It's an unspoken rule that preprocessor directives (#ifdef, ...)
always start at the very beginning of a line to make sure one recognizes
immediately which parts of the code are being processed and which ones aren't.

AFAICS you're not using wine test suite infrastructure, e.g. ok() etc.

Using printf() directly strikes me as being quite bad, too...

Apart from that it appears to be very good.

Thanks!

Andreas Mohr