Re: hnetcfg: [1:10]Define icftype.idl

[Alexandre Julliard]

Jeff Latimer  writes:
> +typedef enum NET_FW_PROFILE_TYPE_
> +{
> - NET_FW_PROFILE_DOMAIN = 1,
> - NET_FW_PROFILE_STANDARD = 2,
> - NET_FW_PROFILE_CURRENT = 3,
> - NET_FW_PROFILE_TYPE_MAX = 4
>
> +}   NET_FW_PROFILE_TYPE;
> -
>
> +typedef enum NET_FW_IP_VERSION_
> +{
> - NET_FW_IP_VERSION_V4 = 1,
> - NET_FW_IP_VERSION_V6 = 2,
> - NET_FW_IP_VERSION_ANY = 3,
> - NET_FW_IP_VERSION_MAX = 4
>
> +}   NET_FW_IP_VERSION;

There's no reason to initialize the enum values explicitly,
particularly since all your values are wrong...

hnetcfg: [1:10]Define icftype.idl

[Jeff L]

Alexandre Julliard wrote:
> There's no reason to initialize the enum values explicitly,
> particularly since all your values are wrong...

My mistake.  I had not got to a point where they were used, so they were 
untested.  The reason I initialised them in the first place I was 
worried about copyright.  I since saw something from about there is no 
copyright when defining an interface as there is only one way to do it.  
How far does that extend?  I rewrote these but is possible to just copy 
them?

Did you have any more to offer about the other patches?

Jeff Latimer

hnetcfg: [1:10]Define icftype.idl

[Alexandre Julliard]

Jeff L  writes:
> My mistake.  I had not got to a point where they were used, so they
> were untested.  The reason I initialised them in the first place I was
> worried about copyright.  I since saw something from about there is no
> copyright when defining an interface as there is only one way to do
> it.  How far does that extend?  I rewrote these but is possible to
> just copy them?

Rewriting them is fine, but there's no reason to add unneeded stuff,
that doesn't make any difference wrt copyright.
> Did you have any more to offer about the other patches?

I didn't look much at them, but you need to do more work on the
sequence, for instance the makefile changes are in patch 7/10 this
means the code in previous patches doesn't even get compiled, that's
very wrong.