Re: [scrrun] Add initial support for Dictionary patch - 1/3

[Jacek Caban]

Hi Vijay

On 06/04/12 12:06, Vijay Kiran Kamuju wrote:
> Sending patch series for initial support for Scripting.Dictionary in scrrun.dll
>
> The first patch will add dictionary.c
> The second will add the necessary changes to Makefile and the scrrun.c
> (mistake done will doing git commit - hence two patches)

This split doesn't make sense. Please merge those patches.

+static ULONG WINAPI dictionary_AddRef(IDictionary *iface)
+{
+    TRACE("%p\n", iface);
+
+    return 2;
+}
+
+static ULONG WINAPI dictionary_Release(IDictionary *iface)
+{
+    TRACE("%p\n", iface);
+
+    return 1;
+}

Dictionary object should be heap-based. That requires proper reference counting and object structure.

Cheers,
Jacek