Oh, that's mostly because I was lazy. I'm pretty sure the text says that "if you are on windows95 you should install winsock2". I'm not sure how to detect whether the user needs to install winsock2 or not by looking at dlls. I was planning on adding detection of the windows version and using that as a way of narrowing down who sees the winsock prompt. That doesn't address which version of winsock the user has installed though...
I'll put in the windows version check so only 95 users see the winsock2 prompt since thats pretty easy.
Chris
From: Ivan Leo Puoti ivanleo@gmail.com Date: 2005/02/08 Tue PM 02:11:29 EST To: cmorgan@alum.wpi.edu CC: wine-devel@winehq.com Subject: Re: winrash bug
Chris Morgan wrote:
Is this based on what the installer displays or upon output from winrash in the debug.txt file?
It is based on the installer telling me I'm on windows 95 and that I must install the winsock2 update for windows 95.
Ivan.
On Tue, 8 Feb 2005, Chris Morgan wrote:
Oh, that's mostly because I was lazy. I'm pretty sure the text says that "if you are on windows95 you should install winsock2". I'm not sure how to detect whether the user needs to install winsock2 or not by looking at dlls.
[...]
Maybe something lkie this would do?
hdll=LoadLibrary("ws2_32.dll"); if (!hdll) { /* You need to install winsock2 */ ... }
Principle taken from autoconf: Check for features, not for the platform, OS version, etc. The above tries to load winsock2 so it will only complain if it is really missing (checking for Windows 95 would complain whether winsock2 is already installed or not).
Great! I had no idea if it was a single or multiple dlls that made up winsock2, this looks like a great way to detect it. I'm almost certain that there is NSIS code that can check for the ability to load up a dll. I'll put that in.
Chris
On Friday 11 February 2005 7:53 am, you wrote:
On Tue, 8 Feb 2005, Chris Morgan wrote:
Oh, that's mostly because I was lazy. I'm pretty sure the text says that "if you are on windows95 you should install winsock2". I'm not sure how to detect whether the user needs to install winsock2 or not by looking at dlls.
[...]
Maybe something lkie this would do?
hdll=LoadLibrary("ws2_32.dll"); if (!hdll) { /* You need to install winsock2 */ ... }Principle taken from autoconf: Check for features, not for the platform, OS version, etc. The above tries to load winsock2 so it will only complain if it is really missing (checking for Windows 95 would complain whether winsock2 is already installed or not).
-
Chris Morgan -
Chris Morgan -
Francois Gouget