On Thursday August 30 2007 07:03, you wrote:
Hello,
I have corrected a patch. Now font in the menu and a font in winecfg coincides.
Your patch still doesn't work correctly. With 120 DPI setting font size in winecfg and notepad menu is different (menu' font is bigger; no so big as before but still bigger). As I have said, in Windows font size is the same in whole system if I change DPI setting and this is (correct) behavior of current WINE too. Please note that your patch behaves even worse at higher DPI resolutions. For example if I set:
"LogPixels"=dword:00000096
...In system.reg then menu font is of ridiculosly big size. In winecfg I have normal font size suitable for my display resolution. In fact, dword:00000096 setting this is what I use in both WINE and Windows (in Windows I can just use "Custom..." menu; in WINE winecfg isn't yet sophisticated enough). In short: if DPI setting changes then font size should change in linear fashion at the same rate for all fonts. Also please explain what exactly you are trying to fix with your patch (what application)? Are you sure that Windows behaves in the same way as you proposing? Test case probably would be nice thing.
Sorry, but purpose of your patch is unclear to me. In your changelog field you tell that "This patch does a font for the menu, statusbar and messages dependent from logpixels" but as far as I know WINE already have correct behavior and respects the LogPixels value (it already sets correct size in menu, status bar and other GUI elements). This is why I'm asking you for an real-world example (with real-world application) of what you are trying to fix.
P.S. Don't forget to reply to wine-devel so others can see the discussion.
В сообщении от Thursday 30 August 2007 12:44:15 вы написали:
Sorry, but purpose of your patch is unclear to me. In your changelog field you tell that "This patch does a font for the menu, statusbar and messages dependent from logpixels" but as far as I know WINE already have correct behavior and respects the LogPixels value (it already sets correct size in menu, status bar and other GUI elements). This is why I'm asking you for an real-world example (with real-world application) of what you are trying to fix.
P.S. Don't forget to reply to wine-devel so others can see the discussion.
This is Screenshot of 1С programm under wine without my patch with option "Too large". We can view that font menu and font of other GUI elements is diffrent.
Test case probably would be nice thing.
ok. I think about it.
On Thursday August 30 2007 09:25, Ivan Sinitsin wrote:
В сообщении от Thursday 30 August 2007 12:44:15 вы написали:
Sorry, but purpose of your patch is unclear to me. In your changelog field you tell that "This patch does a font for the menu, statusbar and messages dependent from logpixels" but as far as I know WINE already have correct behavior and respects the LogPixels value (it already sets correct size in menu, status bar and other GUI elements). This is why I'm asking you for an real-world example (with real-world application) of what you are trying to fix.
P.S. Don't forget to reply to wine-devel so others can see the discussion.
This is Screenshot of 1С programm under wine without my patch with option "Too large". We can view that font menu and font of other GUI elements is diffrent.
Did you try to run this 1C program on Windows? If on Windows it looks like in current WINE without your patch then this is correct and there is nothing to fix - it is already working as it should. Of course, if in Windows it looks differently then this should be fixed. Check this first. Just a note: in Windows program can override your default font size and even DPI setting if they really want this. In anyway your patch shouldn't break correct behavior of almost all programs in WINE! In fact with your patch all programs I have tested (20+ so far) with menus or status bars are broken (extremely large font with my DPI resolution (150); but as I have said before even with standard resolution of 120 DPI fonts are still too big with your patch).
Test case probably would be nice thing.
ok. I think about it.
Good test case will probably help you to write correct patch and will prevent possible regressions in the future; it also will be much easier to get your patch accepted with test case. But as I have said above you need to make sure that on Windows the program in question looks differently and if so try to fix this (without breaking other programs of course).
L. Rahyen wrote:
On Thursday August 30 2007 07:03, you wrote:
Hello,
I have corrected a patch. Now font in the menu and a font in winecfg coincides.
Please note that your patch behaves even worse at higher DPI resolutions. For example if I set:
"LogPixels"=dword:00000096
...In system.reg then menu font is of ridiculosly big size.
I'm not surprised. 0x96 = 150
On Thursday August 30 2007 14:21, Robert Shearman wrote:
L. Rahyen wrote:
On Thursday August 30 2007 07:03, you wrote:
Hello,
I have corrected a patch. Now font in the menu and a font in winecfg coincides.
Please note that your patch behaves even worse at higher DPI resolutions. For example if I set:
"LogPixels"=dword:00000096
...In system.reg then menu font is of ridiculosly big size.
I'm not surprised. 0x96 = 150
Yes, and in both Windows and current WINE (without the patch) this looks very good (as it should) on my 22" display! Just compare attached screenshots (please note that I have scaled down them by 50% in order to save the bandwidth).
"broken.jpg" shows problem I'm talking about. This is with clean WINE with clean WINEPREFIX *with* applied last version of patch that was sent to me privately. As you can see, notepad's dialog and its menu is of ridiculously big size! Behind notepad and winecfg you can see Windows with default font size but with DPI set to 150 (WINE DPI setting is same). Menu in notepad and its dialog is of normal size in Windows, everything looks very nice. Note that all fonts in Windows are of same size no matter what DPI I set there. "clean.jpg" is made using clean WINE with clean WINEPREFIX with LogPixels set to 150 DPI. Behind you can see Windows (in VMWare). Please note that because of clean WINEPREFIX fonts are somewhat different but their system-default size and DPI setting in WINE and Windows are the same here. As you can see, with clean WINE without the patch everything looks as it should. Even the dialog box in both WINE and Windows is of almost same size ("almost" because of somewhat different fonts and different titlebars). This proofs correct behavior of current clean WINE and shows that it respects LogPixels value correctly.
My impression is that the patch Ivan Sinitsin proposing is a hack to make font size in menu/dialog/status bar bigger in every application because 1C application displays smaller fonts there than others. But in its current state this hack is very destructive (as you can see in above example). And of course if on Windows 1C applications behaves in the same way WINE should behave like this too. In fact I have seen (and even use some of them on regular basis) Windows applications which set small font size in some GUI elements even with big DPI setting so I will not be surprised if 1C application in question is just another one.
-
Ivan Sinitsin -
L. Rahyen -
Robert Shearman