Re: Fwd: Patch for https://bugs.winehq.org/show_bug.cgi?id=39759 (Add support for Nvidia GTX TITAN Black card)

[Nikolay Sivov]

On 15.12.2015 20:23, SpinFlo wrote:
> Hi
>
> As said in https://bugs.winehq.org/show_bug.cgi?id=39759#c5
>
> here a patch to add Support for Nvidia GTX TITAN Black card in wine,
> this patch include 3 modifications:
> - Add the info for Nividia GTX TITAN Black card
> - Remove a ',' in a Vram column in NVIDIA GeForce4 Ti 4200 (none of
>
> all cards have this ',', then, i think is a typo)
> - Add some spaces between columns, because the string
>
> 'CARD_NVIDIA_GEFORCE_GTXTITANBLACK},' is too long and breaks the
> look&feel code. some other intel cards have a similar problem in their
> descriptions, then apply spaces un all cards to keep the equality

I can't speak for the maintainer, but it looks easier to use a shorter 
name than rearranging everything.
> Greetings

Fwd: Patch for https://bugs.winehq.org/show_bug.cgi?id=39759 (Add support for Nvidia GTX TITAN Black card)

[Alex Henrie]

Hello, and thank you for your interest in contributing to Wine! Please
review the patch submission guidelines at
http://wiki.winehq.org/SubmittingPatches. When submitting a patch
you have to, at minimum:

- Use your real name.
- Make the subject line identical to what you want to see in the Git commit log.
- Include a Signed-off-by line.

On top of that, it's a good idea to get feedback from the Direct3D
maintainers listed in the MAINTAINERS file before submitting code that
touches this area. Also, we are currently in a code freeze, so unless
this patch is critical it will have to wait until after the 1.8
release.

-Alex