Am 03.10.2015 um 05:39 schrieb Jactry Zeng:
Superseded patch 114739.
ChangeLog: v4:
- Rename driver entry to FlashWindowEx;
- Put FlashWindowEx/pFlashWindowEx in right place;
- Add CDECL for X11DRV_FlashWindowEx.
v3:
- Use x11drv_atom instead of XInternAtom;
- Only do XSendEvent() when data->mapped is true.
v2:
- Use _NET_WM_STATE_DEMANDS_ATTENTION instead of Urgency.
Hi, I haven't looked closer, but normally the implementation should be in the Ex-function and the non-Ex-function should call the Ex-function. In this patch you do Ex->non-Ex->Ex which looks strange.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Am 2015-10-03 um 14:56 schrieb André Hentschel:
I haven't looked closer, but normally the implementation should be in the Ex-function and the non-Ex-function should call the Ex-function. In this patch you do Ex->non-Ex->Ex which looks strange.
I don't have the mail available, but Ken suggested that the Ex->non-ex path in user32 is OK for now, but that he cared about having the right driver entry point.
(https://www.winehq.org/pipermail/wine-devel/2015-September/109474.html) . Of course the question now is how much Alexandre cares about this.
-
André Hentschel -
Stefan Dösinger