I was wondering is there is anyone working on ListView? The reason I ask? I got ACDSee 3.1 installed (see my last patch about typo) & working (well, sort of). It looks like ACDSee depends heavily relies on functionality which is missing from ListView. My question is: if I'll start hacking ListView will I be interfering with someone else's work?
FYI: ACDSee - if not the best, for sure one of the best image viewers. Version 3.1 could be ran in "Sponsored mode" indefinitely as long as it connects to the I-net to get messages & banners.
yes, see many patches onto wine-patches...
--- Vitaliy Margolen wine-devel@kievinfo.com a écrit : > I was wondering is there is anyone working on ListView?
The reason I ask? I got ACDSee 3.1 installed (see my last patch about typo) & working (well, sort of). It looks like ACDSee depends heavily relies on functionality which is missing from ListView. My question is: if I'll start hacking ListView will I be interfering with someone else's work?
FYI: ACDSee - if not the best, for sure one of the best image viewers. Version 3.1 could be ran in "Sponsored mode" indefinitely as long as it connects to the I-net to get messages & banners.
-- Best regards, Vitaliy Margolen
===== Sylvain Petreolle spetreolle@users.sourceforge.net Fight Spam ! EuroCauce: http://www.euro.cauce.org/en/index.html ICQ #170597259
"Don't think you are. Know you are." Morpheus, in "Matrix".
___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com
On March 10, 2003 11:42 am, Vitaliy Margolen wrote:
My question is: if I'll start hacking ListView will I be interfering with someone else's work?
I did a lot of work on the listview recently, but due to new job responsibilities, it's on the backburner ATM. So if you want to work on it, you're welcome! Feel free to ask questions, I'll try to help. BTW, what features does ACDSee need from the listview that are not implemented?
Monday, March 10, 2003, 9:46:27 PM, you wrote:
On March 10, 2003 11:42 am, Vitaliy Margolen wrote:
My question is: if I'll start hacking ListView will I be interfering with someone else's work?
I did a lot of work on the listview recently, but due to new job responsibilities, it's on the backburner ATM. So if you want to work on it, you're welcome! Feel free to ask questions, I'll try to help. BTW, what features does ACDSee need from the listview that are not implemented?
Well, in few words: ListView is badly broken. Here is a list of thing which doesn't work at all, badly broken or missing: 1. Vertical Scroll boundaries are not set properly in Icon and SmallIcon modes. I hacked this one but it's not correct - still missing about 10-20 pixels. Not sure why. 2. ACDSee's Big Icons mode doesn't show anything at all. Not sure what the problem here. It looks like it is possible to select something with keyboard. But still nothing on on the screen. 3. ToolTips not implemented. Not that it's so important. But ACDSee using them for additional info about images. 4. Keyboard navigation in Icon mode is broken. Only right key sorta works. 5. Resizing window does not rearrange icons. Only doing "refresh - F5" rearranges icons in the proper fashion. 6. Biggest mystery to me - some items missing image names. This happens in all modes. ACDSee is using callbacks for text/images. So I'm not sure where the problem is. There are some activity going on with all file names according to trace:string. But GetDispInfo returns blanks. Although thumbnails and preview are displayed properly. 7. In Icon & SmallIcon mouse wheel is reversed.
Basically (1)&(6) are major show stoppers. (4)&(5) needs to be there to make it usable.
There is two more mysteries in ACDSee - TreeView. It's entries are not sorted! But they are under Win. And those folders that don't have names in ListView shown properly in TreeView.
---------------- Vitaliy Margolen
On March 11, 2003 01:41 am, Vitaliy Margolen wrote:
- Vertical Scroll boundaries are not set properly in Icon and SmallIcon
modes. I hacked this one but it's not correct - still missing about 10-20 pixels. Not sure why.
I know, there was on previous bug report about it. Feel free to submit a patch. In general, Icon and SmallIcon modes have more problems than the Report and List modes :(
- ACDSee's Big Icons mode doesn't show anything at
all. Not sure what the problem here. It looks like it is possible to select something with keyboard. But still nothing on on the screen.
Odd -- you'll need to debug this a little. Remember, the listview can't gracefully handle more than 30000 or so items in Icon and SmallIcon mode, so please test with lists smaller than that.
- ToolTips not implemented. Not that it's so important. But ACDSee using
them for additional info about images.
Known -- it's in the TODO. I guess this one can wait, there are other burning problems to solve first :)
- Keyboard navigation in Icon mode is broken. Only right key sorta works.
I know -- keyboard handling has been on my TODO list for some time, but I did not have the time to investigate. Feel free to work on it.
- Resizing window does not rearrange icons. Only doing "refresh - F5"
rearranges icons in the proper fashion.
It should. Can you capture a +listview trace of a resizing event?
- Biggest mystery to me - some items missing image names. This happens in
all modes. ACDSee is using callbacks for text/images. So I'm not sure where the problem is. There are some activity going on with all file names according to trace:string. But GetDispInfo returns blanks. Although thumbnails and preview are displayed properly.
Hmmm. This is strange, it shouldn't do that. Are the missing names always the same?
- In Icon & SmallIcon mouse wheel is reversed.
Try the obvious fix, see if that works :)
Basically (1)&(6) are major show stoppers. (4)&(5) needs to be there to make it usable.
True. If you have patches, post them to the list, so we can discuss them.
There is two more mysteries in ACDSee - TreeView. It's entries are not sorted! But they are under Win. And those folders that don't have names in ListView shown properly in TreeView.
Our treeview is not perfect :) Let's deal with the listview first, it's enough to keep us busy for a while ;).
Tuesday, March 11, 2003, 6:14:22 AM, Dimitrie O. Paun wrote:
On March 11, 2003 01:41 am, Vitaliy Margolen wrote:
- Vertical Scroll boundaries are not set properly in Icon and SmallIcon
modes. I hacked this one but it's not correct - still missing about 10-20 pixels. Not sure why.
I know, there was on previous bug report about it. Feel free to submit a patch. In general, Icon and SmallIcon modes have more problems than the Report and List modes :(
I got it figured out. At least for simplified case. I got a question: tagLISTVIEW_INFO is our structure or it's MS defined one? If former, I can add few more variables to it : maxHight and maxWidth - to track dimensions of ListView. And update it every time on inserts and refreshes.
- ACDSee's Big Icons mode doesn't show anything at
all. Not sure what the problem here. It looks like it is possible to select something with keyboard. But still nothing on on the screen.
Odd -- you'll need to debug this a little. Remember, the listview can't gracefully handle more than 30000 or so items in Icon and SmallIcon mode, so please test with lists smaller than that.
It's mach smaller than that. I had just 10-20 items. I might try with something less sophisticated than ACDSee. Somewhere I have explorer like program written in Delphi. Should be perfect for this.
- Resizing window does not rearrange icons. Only doing "refresh - F5"
rearranges icons in the proper fashion.
It should. Can you capture a +listview trace of a resizing event?
So far it reacts when size get's too small to fit right most column of icons. But nothing when size gets bigger enough for one more column. I will try to get some meaningful logs out of it.
- Biggest mystery to me - some items missing image names. This happens in
all modes. ACDSee is using callbacks for text/images. So I'm not sure where the problem is. There are some activity going on with all file names according to trace:string. But GetDispInfo returns blanks. Although thumbnails and preview are displayed properly.
Hmmm. This is strange, it shouldn't do that. Are the missing names always the same?
Yes missing names are always the same one. One more interesting fact: if directory missing name - all files in it don't have them neither.
Vitaliy Margolen
On March 12, 2003 12:40 am, Vitaliy Margolen wrote:
I got it figured out. At least for simplified case. I got a question: tagLISTVIEW_INFO is our structure or it's MS defined one? If former, I can add few more variables to it : maxHight and maxWidth - to track dimensions of ListView. And update it every time on inserts and refreshes.
Yes, it is our structure. But before you add them, why is it that LISTVIEW_GetAreaRect() does not work for you? It should compute the maxHeight and maxWidth correctly. If it doesn't, I'd rather prefer that we fix it (we may need the maxHeight and maxWidth variables to fix it properly, but I'd like to know why).
Yes missing names are always the same one. One more interesting fact: if directory missing name - all files in it don't have them neither.
Some tracing here would be good. Somehow we probably don't do the callback right, but you have to investigate what the app expects.
Wednesday, March 12, 2003, 5:57:56 AM, you wrote:
On March 12, 2003 12:40 am, Vitaliy Margolen wrote:
I got it figured out. At least for simplified case. I got a question: tagLISTVIEW_INFO is our structure or it's MS defined one? If former, I can add few more variables to it : maxHight and maxWidth - to track dimensions of ListView. And update it every time on inserts and refreshes.
Yes, it is our structure. But before you add them, why is it that LISTVIEW_GetAreaRect() does not work for you? It should compute the maxHeight and maxWidth correctly. If it doesn't, I'd rather prefer that we fix it (we may need the maxHeight and maxWidth variables to fix it properly, but I'd like to know why).
Never mind. I thought it was calling GetItem for every item in a ListView to get it's position. Rather it accessing them directly. I was thinking to optimize this part. If we store and update these variables in the right places... But this gonna be a mess. Too many places that can change position of an item. And what if it's removed?
You were right - I found the bug there. ;-)
Yes missing names are always the same one. One more interesting fact: if directory missing name - all files in it don't have them neither.
Some tracing here would be good. Somehow we probably don't do the callback right, but you have to investigate what the app expects.
So far no luck here. It could be related to TreeView. For whatever reason ACDSee can't set proper path in TreeView. On Windows it opens up correct directory, even if it's a network path.
Next thing: big icons. Something very screwy going on there. Looks to me like each icon somehow gets huge. Even with scrolls fixed, I have both hor&vert bars set to ridiculously big ranges.
On March 13, 2003 02:15 am, Vitaliy Margolen wrote:
Never mind. I thought it was calling GetItem for every item in a ListView to get it's position. Rather it accessing them directly. I was thinking to optimize this part. If we store and update these variables in the right places... But this gonna be a mess. Too many places that can change position of an item. And what if it's removed?
See? You can't really maintain it in a sane manner, I did think about it several times. But regardless, this will get super optimized when we properly support large numbers of items in ICON mode. I have the idea in my head, it's just a matter of coding it... :) I just can't find the time to do it! :(
So far no luck here. It could be related to TreeView. For whatever reason ACDSee can't set proper path in TreeView. On Windows it opens up correct directory, even if it's a network path.
Maybe it's setting the names it gets from the TreeView, and if that is broken, then the problem will get propagated to the listview (even if the listview works correctly).
Next thing: big icons. Something very screwy going on there. Looks to me like each icon somehow gets huge. Even with scrolls fixed, I have both hor&vert bars set to ridiculously big ranges.
This should be easy to trace. As you've seen, to get the scroll range we just get the max of all the origins of all the icons...
-
Dimitrie O. Paun -
Sylvain Petreolle -
Vitaliy Margolen