Re: wine/ windows/defwnd.c dlls/x11drv/x11drv_main ...

[Michael Stefaniuc]

Hi Alexandre,

this patch introduced a regression with FreeSolitaire (free download at 
www.freesolitaire.com). After switching virtual desktops the program 
windows gets blanked (see attached image). The program dosn't lockThis 
seems to be the only program with which i could reproduce this, all the 
others (winemine, notepad, winefile, Flash MX) seem to work just fine.

bye
    michael

Alexandre Julliard wrote:
> ChangeSet ID:	15496
> CVSROOT:	/opt/cvs-commit
> Module name:	wine
> Changes by:	[e-mail]	2005/01/17 13:17:47
>
> Modified files:
>    windows        : defwnd.c 
>    dlls/x11drv    : x11drv_main.c x11drv.h winpos.c window.c 
>                     scroll.c mouse.c event.c clipboard.c
>
> Log message:
>    Avoid most references to the internals of the WND structure by passing
>    around an x11drv_win_data pointer instead.
>
> Patch: http://cvs.winehq.org/patch.py?id=15496
>
> Old revision  New revision  Changes     Path
>  1.99          1.100         +0 -3       wine/windows/defwnd.c
>  1.97          1.98          +0 -1       wine/dlls/x11drv/x11drv_main.c
>  1.42          1.43          +17 -24     wine/dlls/x11drv/x11drv.h
>  1.109         1.110         +76 -86     wine/dlls/x11drv/winpos.c
>  1.87          1.88          +213 -199   wine/dlls/x11drv/window.c
>  1.21          1.22          +0 -1       wine/dlls/x11drv/scroll.c
>  1.16          1.17          +3 -6       wine/dlls/x11drv/mouse.c
>  1.40          1.41          +5 -4       wine/dlls/x11drv/event.c
>  1.30          1.31          +0 -1       wine/dlls/x11drv/clipboard.c

wine/ windows/defwnd.c dlls/x11drv/x11drv_main ...

[Alexandre Julliard]

Michael Stefaniuc  writes:
> Hi Alexandre,
>
> this patch introduced a regression with FreeSolitaire (free download
> at www.freesolitaire.com). After switching virtual desktops the
> program windows gets blanked (see attached image). The program dosn't
> lockThis seems to be the only program with which i could reproduce
> this, all the others (winemine, notepad, winefile, Flash MX) seem to
> work just fine.

I don't see the problem here, I'm afraid you'll have to debug this
yourself. Maybe try a +win,+event,+x11drv trace with and without the
patch and look for a difference around the area where you switch
virtual desktops.

wine/ windows/defwnd.c dlls/x11drv/x11drv_main ...

[Michael Stefaniuc]

Hi,

Alexandre Julliard wrote:
> Michael Stefaniuc  writes:
> > this patch introduced a regression with FreeSolitaire (free download
> > at www.freesolitaire.com). After switching virtual desktops the
> > program windows gets blanked (see attached image). The program dosn't
> > lockThis seems to be the only program with which i could reproduce
> > this, all the others (winemine, notepad, winefile, Flash MX) seem to
> > work just fine.
>
> I don't see the problem here, I'm afraid you'll have to debug this
> yourself. Maybe try a +win,+event,+x11drv trace with and without the
> patch and look for a difference around the area where you switch
> virtual desktops.

Didn't had the time to look into this (was in US for 2 weeks) and now 
the regression resolved itself automagicly.

bye
    michael