Re: [ddraw/tests] Fix a test on W2K3

[chris ahrendt]

Paul Vriens wrote:
> Henri Verbeet wrote:
> > 2008/11/4 Paul Vriens :
> > > Hi,
> > >
> > > I upgraded to VMware 6.5.0 this morning and overlay tests are run now on my
> > > W2K3
> > > box. As the return value indicates E_NOTIMPL I decided to add a skip() for
> > > one particular test.
> >
> > VMware is not a valid test platform for ddraw.
>
> And how would you like to approach that? Most of us run tests on some piece of 
> virtualization software. Should we check for VMware and don't run d3d8/9/10 and 
> ddraw tests anymore at all? We do want to have a green test.winehq.org after all.
>
> I agree that we shouldn't use VMware as a valid test platform for ddraw but as 
> long as the skips are kept to a minimum can't we live with that?
>
> (What would have happened with the patch when I wouldn't have mentioned VMware?)

Actually as of 6.5 of VMWARE direct draw 9c is 100% supported. So why 
couldn't we use vmware 6.5
as a valid platform for testing direct draw api's?

chris

[ddraw/tests] Fix a test on W2K3

[Detlef Riekenberg]

On Di, 2008-11-04 at 10:25 -0800, chris ahrendt wrote:
> >
>
> Actually as of 6.5 of VMWARE direct draw 9c is 100% supported. So why 
> couldn't we use vmware 6.5
> as a valid platform for testing direct draw api's?

When our tests use valid data but received an E_NOTIMPL,
then DirectX 9c in VMWare 6.5 is for sure not 100% implemented.
In that case, the correct way to avoid the failure in the test is
an update for VMware.

The previous VMWare Printer-Driver also produced a failure
(didn't checked the results for the new version)

They are free to use our tests to fix there Drivers.