Re: [PATCH 1/6] d3drm: Introduce d3drm_texture_destroy helper (v2).

[Henri Verbeet]

On 11 May 2016 at 16:43, Aaryaman Vasishta  wrote:
> +void d3drm_texture_destroy(struct d3drm_texture *texture)
> +{
> - d3drm_object_cleanup((IDirect3DRMObject*)&texture->IDirect3DRMTexture3_iface, &texture->obj);
> - HeapFree(GetProcessHeap(), 0, texture);
>
> +}

You're not using d3drm_texture_destroy() outside texture.c, so you
don't need the declaration in d3drm_private.h, and this should just be
static.

[PATCH 1/6] d3drm: Introduce d3drm_texture_destroy helper (v2).

[Aaryaman Vasishta]

Right, I didn't pay attention to d3drm_private.h while reviewing the
commits :/ my bad.

I'll resend this one.

Cheers,
Aaryaman

On Wed, May 11, 2016 at 9:13 PM, Henri Verbeet  wrote:
> On 11 May 2016 at 16:43, Aaryaman Vasishta 
> wrote:
> > +void d3drm_texture_destroy(struct d3drm_texture *texture)
> > +{
> > -
>
> d3drm_object_cleanup((IDirect3DRMObject*)&texture->IDirect3DRMTexture3_iface,
> &texture->obj);
> > - HeapFree(GetProcessHeap(), 0, texture);
> >
> > +}
>
> You're not using d3drm_texture_destroy() outside texture.c, so you
> don't need the declaration in d3drm_private.h, and this should just be
> static.