Re: [PATCH] shell32: Implement knownfolder_GetRedirectionCapabilities somewhat

[Nikolay Sivov]

On 23.01.2017 23:10, Enrico Horn wrote:
> This is the one thing missing to get the config app for Temple+, a
> Temple of Elemental Evil Mod, starting.
>
> dlls/shell32/shellpath.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c
> index 92306239db7..3c44ecb393a 100644
> --- a/dlls/shell32/shellpath.c
> +++ b/dlls/shell32/shellpath.c
> @@ -5396,8 +5396,9 @@ static HRESULT WINAPI knownfolder_GetRedirectionCapabilities(
>      IKnownFolder *iface,
>      KF_REDIRECTION_CAPABILITIES *pCapabilities)
>  {
> - FIXME("%p\n", pCapabilities);
> - return E_NOTIMPL;
> - FIXME("%p - always denied\n", pCapabilities);
> - *pCapabilities = KF_REDIRECTION_CAPABILITIES_DENY_ALL;
> - return S_OK;
>
> }
>
> static HRESULT WINAPI knownfolder_GetFolderDefinition(

Do we have an open bug for that? If it's just a matter of returning
static data, it's trivial to fix without any hacks.

[PATCH] shell32: Implement knownfolder_GetRedirectionCapabilities somewhat

[Farmboy0]

On 23.01.2017 23:59, Nikolay Sivov wrote:
> On 23.01.2017 23:10, Enrico Horn wrote:
> > This is the one thing missing to get the config app for Temple+, a
> > Temple of Elemental Evil Mod, starting.
> >
> > dlls/shell32/shellpath.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c
> > index 92306239db7..3c44ecb393a 100644
> > --- a/dlls/shell32/shellpath.c
> > +++ b/dlls/shell32/shellpath.c
> > @@ -5396,8 +5396,9 @@ static HRESULT WINAPI knownfolder_GetRedirectionCapabilities(
> >      IKnownFolder *iface,
> >      KF_REDIRECTION_CAPABILITIES *pCapabilities)
> >  {
> > - FIXME("%p\n", pCapabilities);
> > - return E_NOTIMPL;
> > - FIXME("%p - always denied\n", pCapabilities);
> > - *pCapabilities = KF_REDIRECTION_CAPABILITIES_DENY_ALL;
> > - return S_OK;
> >
> > }
> >
> > static HRESULT WINAPI knownfolder_GetFolderDefinition(
>
> Do we have an open bug for that? If it's just a matter of returning
> static data, it's trivial to fix without any hacks.

There is no bug for this.

I was just trying to get that app to run.

If you have a better way to solve this I can test it.